Skip to content

s/draws -> s/draw #7797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
williambdean opened this issue May 23, 2025 · 5 comments
Open

s/draws -> s/draw #7797

williambdean opened this issue May 23, 2025 · 5 comments

Comments

@williambdean
Copy link
Contributor

williambdean commented May 23, 2025

the denominator should be singular imo

pymc/pymc/util.py

Lines 866 to 868 in c8d83ca

else:
unit = "s/draws"
speed = 1 / speed

Or should be seconds/draw

@ricardoV94
Copy link
Member

See also #7750

@jessegrabowski
Copy link
Member

Agreed this is wrong

@williambdean
Copy link
Contributor Author

I'm in favor of writing out the numerator in this case. i.e. seconds

@jessegrabowski
Copy link
Member

I'm worried it's too long and will stretch the column height with a line break

@williambdean
Copy link
Contributor Author

only one way to find out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants