Skip to content

BUG: PrecisionMvNormalRV missing factor of 1/2 for log determinant in logp function #7751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ckrapu opened this issue Apr 7, 2025 · 2 comments · May be fixed by #7811
Open

BUG: PrecisionMvNormalRV missing factor of 1/2 for log determinant in logp function #7751

ckrapu opened this issue Apr 7, 2025 · 2 comments · May be fixed by #7811
Labels
bug hackathon Suitable for hackathon

Comments

@ckrapu
Copy link
Contributor

ckrapu commented Apr 7, 2025

Describe the issue:

At this line,

logp = -0.5 * (k * pt.log(2 * np.pi) + quadratic_form) + logdet

should be

logp = -0.5 * (k * pt.log(2 * np.pi) + quadratic_form + logdet)

Reproduceable code example:

N/A

Error message:

PyMC version information:

5.21.1

Context for the issue:

No response

@ckrapu ckrapu added the bug label Apr 7, 2025
@ricardoV94
Copy link
Member

@ckrapu wanna open a PR by any chance?

@shanegladson
Copy link

@ckrapu wanna open a PR by any chance?

This issue seems inactive so I'm happy to take it over if available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug hackathon Suitable for hackathon
Projects
None yet
4 participants