Skip to content

Use trusted publisher for PyPI releases #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 3 tasks
trallard opened this issue Apr 4, 2024 · 4 comments · Fixed by #1758
Closed
2 of 3 tasks

Use trusted publisher for PyPI releases #1754

trallard opened this issue Apr 4, 2024 · 4 comments · Fixed by #1758
Labels
kind: enhancement New feature or request tag: team process Team process, governance, and guidelines

Comments

@trallard
Copy link
Collaborator

trallard commented Apr 4, 2024

We use the publish.yaml workflow for PST releases.

This still uses a token for this action, though trusted publishing is now encouraged over API tokens as a best practice on supported platforms (like GitHub).

To do this, we would need to:

  • Update publish.yaml - I can do this
  • Update the settings in the PyPI package to enable trusted publishers. I'm not sure who has access to this, but maybe @choldgraf (?).
  • Remove the existing token from GH

Ref: https://docs.pypi.org/trusted-publishers/adding-a-publisher/

@trallard trallard added kind: enhancement New feature or request tag: team process Team process, governance, and guidelines labels Apr 4, 2024
@choldgraf
Copy link
Collaborator

@trallard I've invited you as an owner on pypi (and recommend we add other core maintainers in the same role as well)

@drammock
Copy link
Collaborator

drammock commented Apr 4, 2024

Feel free to add me if you want, we use trusted publisher in MNE too so I'm familiar

@trallard
Copy link
Collaborator Author

trallard commented Apr 5, 2024

Added you @drammock!

@trallard
Copy link
Collaborator Author

trallard commented Apr 5, 2024

PR is up now at #1758; the only outstanding item is removing the existing tokens from GitHub itself.
This is not something I can do with my current permissions/role, so this would be a task for someone else with elevated privileges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement New feature or request tag: team process Team process, governance, and guidelines
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants