Skip to content

proposal: adopt precommit.ci #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
drammock opened this issue Feb 12, 2024 · 0 comments · Fixed by #1752
Closed

proposal: adopt precommit.ci #1718

drammock opened this issue Feb 12, 2024 · 0 comments · Fixed by #1752
Labels
tag: team process Team process, governance, and guidelines

Comments

@drammock
Copy link
Collaborator

It's a CI action that runs our pre-commit hooks in a CI action, and can be configured to auto-fix some failures. https://pre-commit.ci/

Would have saved some effort in #1711, for example. @trallard is in favor (see #1711 (comment)), and I'm on board too (we use it in other projects I work on).

Any objections? The main downside is that for users not super familiar with git, having a bot add commits to your PR can potentially be a bit confusing / cause subsequent pushes to fail until you've done git pull --rebase or similar. But IMO git's error messages are quite clear/instructive in that particular case, and in my experience the bot solves more problems than it creates.

@trallard trallard added the tag: team process Team process, governance, and guidelines label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: team process Team process, governance, and guidelines
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants