-
Notifications
You must be signed in to change notification settings - Fork 339
Allow renaming of the header dropdown #1386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for raising this @AlenkaF - I think this would be a good enhancement. Additionally, come to think about it, from an accessibility POV using only the word "More" as the default label/title is not descriptive enough (I'd place it under the understandable category of WCAG POUR. This is somewhat related but not the same as WCAG SC 2.4.4: Link Purpose (In Context), so the default could be improved by adopting something like |
@trallard the issue I see with "More sections" is the real estate it takes in the header navbar compared to "More", In many cases people will be forced to decrease the number of displayed link by 1 to maintain readability on medium screens. |
I'm not opposed to allowing users to customize the dropdown name. The suggestion of "more sections" seems like it's not appropriate for our specific site, since what we put in there are external links (not sections). Also not sure what a better default would be since we don't know (without some research / surveying at least) whether most projects include external links or just sections. But maybe we can brainstorm something generic enough to encompass both sections and external links? |
You are right @drammock - it would be ideal to have a good picture of what folks are using the dropdown for (I chose "More sections" as a proxy, but admittedly this might only fit my mental model of what I'd use it for). At least allowing folks to customise the dropdown name would help mitigate this on their end and better reflect their use cases and content. |
Apologies for skipping your comment @12rambau 🙇🏽 |
Thank you all for showing interest in the issue! I will go ahead and try to submit a PR with the proposal for the configurable header dropdown button name in the coming days. Regarding the default name of the button - maybe this would deserve a separate issue? |
Awesome, thanks!
I think leave it as "more" for now and we'll revisit if someone comes up with a popular alternative |
Currently the header dropdown generated after
n_links_before_dropdown
is by default namedMore
. It would be a nice feature if one could group remaining header links into a dropdown with a custom name.One option I see is that
generate_header_nav_html
could accept an argument to use when wrapping the final few header items in a "More" dropdown:pydata-sphinx-theme/src/pydata_sphinx_theme/toctree.py
Lines 131 to 143 in 92445e9
Maybe related to #1016
The text was updated successfully, but these errors were encountered: