Skip to content

Commit 8a75898

Browse files
authored
Make some handshakes in tests less flaky. (#1163)
1 parent 8ba3392 commit 8a75898

File tree

1 file changed

+13
-12
lines changed

1 file changed

+13
-12
lines changed

tests/test_ssl.py

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
import datetime
99
import gc
10+
import select
1011
import sys
1112
import uuid
1213
from errno import (
@@ -1297,20 +1298,20 @@ def _handshake_test(self, serverContext, clientContext):
12971298
"""
12981299
serverSocket, clientSocket = socket_pair()
12991300

1300-
server = Connection(serverContext, serverSocket)
1301-
server.set_accept_state()
1301+
with serverSocket, clientSocket:
1302+
server = Connection(serverContext, serverSocket)
1303+
server.set_accept_state()
13021304

1303-
client = Connection(clientContext, clientSocket)
1304-
client.set_connect_state()
1305+
client = Connection(clientContext, clientSocket)
1306+
client.set_connect_state()
13051307

1306-
# Make them talk to each other.
1307-
# interact_in_memory(client, server)
1308-
for _ in range(3):
1309-
for s in [client, server]:
1310-
try:
1311-
s.do_handshake()
1312-
except WantReadError:
1313-
pass
1308+
# Make them talk to each other.
1309+
for _ in range(3):
1310+
for s in [client, server]:
1311+
try:
1312+
s.do_handshake()
1313+
except WantReadError:
1314+
select.select([client, server], [], [])
13141315

13151316
def test_set_verify_callback_connection_argument(self):
13161317
"""

0 commit comments

Comments
 (0)