Provider did not catch 400 error returned from the API (mongodb#687)

Co-authored-by: admin <[email protected]>

Author: martinstibbe

mongodbatlas/resource_mongodbatlas_advanced_cluster.go

@@ -583,6 +583,9 @@ func resourceMongoDBAtlasAdvancedClusterUpdate(ctx context.Context, d *schema.Re
 						return resource.NonRetryableError(fmt.Errorf(errorClusterAdvancedUpdate, clusterName, err))
 					}
 				}
+				if errors.As(err, &target) && target.HTTPCode == 400 {
+					return resource.NonRetryableError(fmt.Errorf(errorClusterAdvancedUpdate, clusterName, err))
+				}
 			}
 			return nil
 		})

mongodbatlas/resource_mongodbatlas_cluster.go

@@ -915,6 +915,9 @@ func resourceMongoDBAtlasClusterUpdate(ctx context.Context, d *schema.ResourceDa
 						return resource.NonRetryableError(fmt.Errorf(errorClusterUpdate, clusterName, err))
 					}
 				}
+				if errors.As(err, &target) && target.HTTPCode == 400 {
+					return resource.NonRetryableError(fmt.Errorf(errorClusterUpdate, clusterName, err))
+				}
 			}
 			return nil
 		})