Skip to content

Commit 29f922b

Browse files
committed
DB E2E/integration tests: disable .realtimeDataUpdatedAt validation ✅
remotely related: #331
1 parent 8432ff1 commit 29f922b

File tree

2 files changed

+21
-11
lines changed

2 files changed

+21
-11
lines changed

test/e2e/db.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ const cfg = {
4242
minLongitude: 6.896517,
4343
maxLongitude: 16.180237,
4444
validateJourneyTickets: false, // don't validate a journey's tickets
45+
// with `journeys()` & `refreshJourney()`, don't validate .realtimeDataUpdatedAt
46+
validateJourneysRealtimeDataUpdatedAt: false,
4547
};
4648

4749
const validate = createValidate(cfg);

test/e2e/lib/validators.js

Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -440,23 +440,31 @@ const validateJourneys = (val, js, name = 'journeys') => {
440440
};
441441
const createValidateJourneys = () => validateJourneys;
442442

443-
const validateJourneysResult = (val, res, name = 'journeysResult') => {
444-
a.ok(isObj(res), name + ' must be an object');
445-
// todo: `earlierRef`, `laterRef`
446-
val.journeys(val, res.journeys, name + '.journeys');
443+
const createValidateJourneysResult = (cfg) => {
444+
const validateJourneysResult = (val, res, name = 'journeysResult') => {
445+
a.ok(isObj(res), name + ' must be an object');
446+
// todo: `earlierRef`, `laterRef`
447+
val.journeys(val, res.journeys, name + '.journeys');
447448

448-
val.realtimeDataUpdatedAt(val, res.realtimeDataUpdatedAt, name + '.realtimeDataUpdatedAt');
449+
if (cfg.validateJourneysRealtimeDataUpdatedAt !== false) {
450+
val.realtimeDataUpdatedAt(val, res.realtimeDataUpdatedAt, name + '.realtimeDataUpdatedAt');
451+
}
452+
};
453+
return validateJourneysResult;
449454
};
450-
const createValidateJourneysResult = () => validateJourneysResult;
451455

452-
const validateRefreshJourneyResult = (val, res, name = 'refreshJourneyResult') => {
453-
a.ok(isObj(res), name + ' must be an object');
456+
const createValidateRefreshJourneyResult = (cfg) => {
457+
const validateRefreshJourneyResult = (val, res, name = 'refreshJourneyResult') => {
458+
a.ok(isObj(res), name + ' must be an object');
454459

455-
val.realtimeDataUpdatedAt(val, res.realtimeDataUpdatedAt, name + '.realtimeDataUpdatedAt');
460+
if (cfg.validateJourneysRealtimeDataUpdatedAt !== false) {
461+
val.realtimeDataUpdatedAt(val, res.realtimeDataUpdatedAt, name + '.realtimeDataUpdatedAt');
462+
}
456463

457-
val.journey(val, res.journey, name + '.journey');
464+
val.journey(val, res.journey, name + '.journey');
465+
};
466+
return validateRefreshJourneyResult;
458467
};
459-
const createValidateRefreshJourneyResult = () => validateRefreshJourneyResult;
460468

461469
const validateTrip = (val, trip, name = 'trip') => {
462470
const withFakeTripId = Object.assign({

0 commit comments

Comments
 (0)