Skip to content

Commit 7649431

Browse files
committed
Merge bitcoin/bitcoin#28105: doc: Clarify that -fstack-reuse=all bugs exist on all versions of GCC
fabb419 doc: Clarify that -fstack-reuse=all bugs exist on all versions of GCC (MarcoFalke) Pull request description: This is a follow-up to commit 7b850bc. While the test case no longer reproduces, the general class of `-fstack-reuse` bugs still exists in all versions of GCC. The workaround can never be removed, unless the whole class of bugs is fixed. ACKs for top commit: fanquake: ACK fabb419 Tree-SHA512: 566e14fe82d13dda4f7b8cca90c6de75006d14828906b936780716d5b5b31de9b36a904aa7cfc9820ccdfb4d3224a8437f502f25f7230da5abe87c927123f0c8
2 parents 578f50f + fabb419 commit 7649431

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

configure.ac

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -941,9 +941,8 @@ if test "$TARGET_OS" != "windows"; then
941941
AX_CHECK_COMPILE_FLAG([-fPIC], [PIC_FLAGS="-fPIC"])
942942
fi
943943

944-
dnl Versions of gcc prior to 12.1 (commit
945-
dnl https://github.com/gcc-mirror/gcc/commit/551aa75778a4c5165d9533cd447c8fc822f583e1)
946-
dnl are subject to a bug, see the gccbug_90348 test case and
944+
dnl Currently all versions of gcc are subject to a class of bugs, see the
945+
dnl gccbug_90348 test case (only reproduces on GCC 11 and earlier) and the related bugs of
947946
dnl https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90348. To work around that, set
948947
dnl -fstack-reuse=none for all gcc builds. (Only gcc understands this flag)
949948
AX_CHECK_COMPILE_FLAG([-fstack-reuse=none], [HARDENED_CXXFLAGS="$HARDENED_CXXFLAGS -fstack-reuse=none"])

0 commit comments

Comments
 (0)