Improve failure message in AbstractSimpleTransportTestCase (opensearch-project#18321)

andrross · web-flow · commit 3dd4b8e4403d · 2025-05-20T13:31:56.000-07:00
Signed-off-by: Andrew Ross &lt;andrross@amazon.com&gt;
diff --git a/test/framework/src/main/java/org/opensearch/transport/AbstractSimpleTransportTestCase.java b/test/framework/src/main/java/org/opensearch/transport/AbstractSimpleTransportTestCase.java
@@ -2074,7 +2074,7 @@ public void handleException(TransportException exp) {
                 logger.debug((Supplier<?>) () -> new ParameterizedMessage("---> received exception for id {}", id), exp);
                 allRequestsDone.countDown();
                 Throwable unwrap = ExceptionsHelper.unwrap(exp, IOException.class);
-                assertNotNull(unwrap);
+                assertNotNull("Expected an IOException somewhere in causal chain: " + exp, unwrap);
                 assertEquals(IOException.class, unwrap.getClass());
                 assertEquals("forced failure", unwrap.getMessage());
             }

Original file line number	Diff line number	Diff line change
`@@ -2074,7 +2074,7 @@ public void handleException(TransportException exp) {`
`2074`	`2074`	`logger.debug((Supplier<?>) () -> new ParameterizedMessage("---> received exception for id {}", id), exp);`
`2075`	`2075`	`allRequestsDone.countDown();`
`2076`	`2076`	`Throwable unwrap = ExceptionsHelper.unwrap(exp, IOException.class);`
`2077`		`- assertNotNull(unwrap);`
	`2077`	`+ assertNotNull("Expected an IOException somewhere in causal chain: " + exp, unwrap);`
`2078`	`2078`	`assertEquals(IOException.class, unwrap.getClass());`
`2079`	`2079`	`assertEquals("forced failure", unwrap.getMessage());`
`2080`	`2080`	`}`