Skip to content

Commit 4fec0a5

Browse files
committed
Keep latest 3 Go versions in supported_go_versions
Signed-off-by: Sachin Sahu <[email protected]>
1 parent 74a9e0b commit 4fec0a5

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Makefile

+1-2
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@ test-short: deps common-test-short
2222

2323
.PHONY: generate-go-collector-test-files
2424
file := supported_go_versions.txt
25-
# take top 3 versions
26-
VERSIONS := $(shell cat ${file} | head -n 3)
25+
VERSIONS := $(shell cat ${file})
2726
generate-go-collector-test-files:
2827
for GO_VERSION in $(VERSIONS); do \
2928
docker run \

update-go-version.bash

+2-1
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,12 @@ current_version=$(cat supported_go_versions.txt | head -n 1)
1010
latest_version=$(get_latest_versions)
1111

1212
# Check for new version of Go, and generate go collector test files
13-
# New Go version gets appended at top of supported_go_versions.txt, and only top 3 versions are supported
13+
# Add new Go version to supported_go_versions.txt, and remove the oldest version
1414
if [[ ! $current_version =~ $latest_version ]]; then
1515
echo "New Go version available: $latest_version"
1616
echo "Updating supported_go_versions.txt and generating Go Collector test files"
1717
sed -i "1i $latest_version" supported_go_versions.txt
18+
sed -i '$d' supported_go_versions.txt
1819
make generate-go-collector-test-files
1920
else
2021
echo "No new Go version detected. Current Go version is: $current_version"

0 commit comments

Comments
 (0)