Skip to content

theme_style is not correctly used #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thvdveld opened this issue Oct 26, 2021 · 4 comments · Fixed by #130
Closed

theme_style is not correctly used #129

thvdveld opened this issue Oct 26, 2021 · 4 comments · Fixed by #130
Assignees
Labels
assigned Under progress.

Comments

@thvdveld
Copy link

thvdveld commented Oct 26, 2021

When setting theme_style to dark_default and setting vim.o.background = "dark" before setting the theme, the theme I get is the dark theme and not the dark_default theme.

require('github-theme').setup({
    theme_style = 'dark_default',
})

Everything seems to be working when using commit 771ac5b, such as @jsgv suggested in #113.

@ful1e5 ful1e5 self-assigned this Oct 26, 2021
@ful1e5 ful1e5 added the assigned Under progress. label Oct 26, 2021
@ful1e5 ful1e5 changed the title themed_style is not correctly used theme_style is not correctly used Oct 26, 2021
@ful1e5
Copy link
Member

ful1e5 commented Oct 26, 2021

I just pushed some commits regarding the config module on my fork. Give it try.

-- packer config
use {"ful1e5/github-nvim-theme", branch = "fix/vim-background-config"}

Repo link

https://github.com/ful1e5/github-nvim-theme/tree/fix/vim-background-config

@thvdveld
Copy link
Author

Seems to be working for me!

@ful1e5
Copy link
Member

ful1e5 commented Oct 26, 2021

I just pushed some commits regarding the config module on my fork. Give it try.

-- packer config
use {"ful1e5/github-nvim-theme", branch = "fix/vim-background-config"}

Repo link

https://github.com/ful1e5/github-nvim-theme/tree/fix/vim-background-config

@jsec

@kdheepak
Copy link

I'm having a similar issue (with a light background and using the light theme), and using the repo link with that branch works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned Under progress.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants