Skip to content

Commit ff1a341

Browse files
authored
Merge pull request #1117 from wahabmk/fix-helm-plainhttp-bug
Fix for failing to deploy helm chart from plain HTTP registry
2 parents 6e25e99 + 17bea1c commit ff1a341

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

controllers/handlers_helm.go

+2-3
Original file line numberDiff line numberDiff line change
@@ -837,6 +837,8 @@ func createRegistryClientOptions(ctx context.Context, clusterSummary *configv1be
837837

838838
registryOptions.credentialsPath = credentialsPath
839839
registryOptions.caPath = caPath
840+
registryOptions.plainHTTP = getPlainHTTP(currentChart)
841+
registryOptions.skipTLSVerify = getInsecureSkipTLSVerify(currentChart)
840842

841843
if currentChart.RegistryCredentialsConfig.CredentialsSecretRef != nil {
842844
credentialSecretNamespace := libsveltostemplate.GetReferenceResourceNamespace(clusterSummary.Spec.ClusterNamespace,
@@ -861,9 +863,6 @@ func createRegistryClientOptions(ctx context.Context, clusterSummary *configv1be
861863
registryOptions.username = username
862864
registryOptions.password = password
863865
registryOptions.hostname = hostname
864-
865-
registryOptions.plainHTTP = getPlainHTTP(currentChart)
866-
registryOptions.skipTLSVerify = getInsecureSkipTLSVerify(currentChart)
867866
}
868867

869868
return registryOptions, nil

0 commit comments

Comments
 (0)