Skip to content

Commit cb2e652

Browse files
Merge pull request #5436 from ShuBo6/dev
fix: Missing close statements file.Close() & ticker.Stop()
2 parents 1fa0e2b + c5a3949 commit cb2e652

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

internal/pdcp/writer.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ func (u *UploadWriter) autoCommit(ctx context.Context, r *io.PipeReader) {
142142
// temporary buffer to store the results
143143
buff := &bytes.Buffer{}
144144
ticker := time.NewTicker(flushTimer)
145-
145+
defer ticker.Stop()
146146
for {
147147
select {
148148
case <-ctx.Done():

pkg/scan/charts/echarts.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ func (s *ScanEventsCharts) GenerateHTML(filePath string) error {
3030
if err != nil {
3131
return err
3232
}
33+
defer output.Close()
3334
return page.Render(output)
3435
}
3536

pkg/scan/events/stats_build.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ func (s *ScanStatsWorker) initEventsFile() error {
5656
if err != nil {
5757
return err
5858
}
59+
defer f.Close()
5960
s.enc = json.NewEncoder(f)
6061
return nil
6162
}

0 commit comments

Comments
 (0)