enable linting on whole repo on github workflow, unify yamlling config, more minor fixes

Author: coutinhop

.github/workflows/yamllint.yml

@@ -15,8 +15,9 @@ name: Yaml Lint
 on:  # yamllint disable-line rule:truthy
   pull_request:
     paths:
-      - '.semaphore/**/*.yml'
-      - '.semaphore/.yamllint.yml'
+      - '*.yml'
+      - '*.yaml'
+      - '.yamllint'
 
 jobs:
   lintSemaphoreYaml:
@@ -26,8 +27,8 @@ jobs:
       - id: yaml-lint
         uses: ibiqlik/action-yamllint@v3
         with:
-          file_or_dir: .semaphore/**/*.yml
-          config_file: .semaphore/.yamllint.yml
+          file_or_dir: ./
+          config_file: .yamllint
       - uses: actions/upload-artifact@v4
         if: always()
         with:

.yamllint renamed to .yamllint.yaml

@@ -1,12 +1,18 @@
 ---
 
-extends: relaxed
+extends: default
 
 rules:
   line-length: disable
+  document-start: disable
+  truthy: disable
   indentation:
     spaces: consistent
     indent-sequences: consistent
+  comments:
+    require-starting-space: false
+    min-spaces-from-content: 1
+  comments-indentation: disable
 
 ignore:
   # template files are not valid yaml

charts/calico/templates/calico-node-rbac.yaml

@@ -119,7 +119,7 @@ rules:
       - get
       - list
       - watch
-   # Calico creates some tiers on startup.
+  # Calico creates some tiers on startup.
   - apiGroups: ["crd.projectcalico.org"]
     resources:
       - tiers

charts/calico/templates/calico-node.yaml

@@ -470,9 +470,9 @@ spec:
         # This container runs flannel using the kube-subnet-mgr backend
         # for allocating subnets.
         - name: kube-flannel
-          image: {{ .Values.flannel.image }}:{{ .Values.flannel.tag }}
+          image: {{.Values.flannel.image}}:{{.Values.flannel.tag}}
           imagePullPolicy: {{.Values.imagePullPolicy}}
-          command: [ "/opt/bin/flanneld", "--ip-masq", "--kube-subnet-mgr" ]
+          command: ["/opt/bin/flanneld", "--ip-masq", "--kube-subnet-mgr"]
           securityContext:
             privileged: true
           env:

manifests/calico-bpf.yaml

@@ -313,7 +313,7 @@ rules:
       - get
       - list
       - watch
-   # Calico creates some tiers on startup.
+  # Calico creates some tiers on startup.
   - apiGroups: ["crd.projectcalico.org"]
     resources:
       - tiers

manifests/calico-policy-only.yaml

@@ -6,4 +6,4 @@ metadata:
 type: Opaque
 data:
   # Admin password in Base64 format is used by Linux and Windows VMSS manifests. However login with user/password is disabled on Linux.
-  password: {{ .Env.PASSWORD_BASE64 }}
+  password: {{.Env.PASSWORD_BASE64}}

manifests/calico-typha.yaml

@@ -7,7 +7,7 @@ metadata:
 apiVersion: resources.azure.com/v1api20200601
 kind: ResourceGroup
 metadata:
-  name: {{ .Env.AZURE_RESOURCE_GROUP }}
+  name: {{.Env.AZURE_RESOURCE_GROUP}}
   namespace: winfv
 spec:
-  location: {{ .Env.AZURE_LOCATION }}
+  location: {{.Env.AZURE_LOCATION}}

manifests/calico-vxlan.yaml

@@ -4,9 +4,9 @@ metadata:
   name: winfv-sg
   namespace: winfv
 spec:
-  location: {{ .Env.AZURE_LOCATION }}
+  location: {{.Env.AZURE_LOCATION}}
   owner:
-    name: {{ .Env.AZURE_RESOURCE_GROUP }}
+    name: {{.Env.AZURE_RESOURCE_GROUP}}
 
 ---
 apiVersion: network.azure.com/v1api20201101

manifests/calico.yaml

@@ -4,13 +4,13 @@ metadata:
   name: vmss-linux
   namespace: winfv
 spec:
-  location: {{ .Env.AZURE_LOCATION }}
+  location: {{.Env.AZURE_LOCATION}}
   owner:
-    name: {{ .Env.AZURE_RESOURCE_GROUP }}
+    name: {{.Env.AZURE_RESOURCE_GROUP}}
   platformFaultDomainCount: 1
   singlePlacementGroup: false
   sku:
-    capacity: {{ .Env.LINUX_NODE_COUNT }}
+    capacity: {{.Env.LINUX_NODE_COUNT}}
     name: Standard_D4s_v3
   upgradePolicy:
     mode: Automatic
@@ -52,7 +52,7 @@ spec:
         disablePasswordAuthentication: true
         ssh:
           publicKeys:
-            - keyData: {{ .Env.PUBLIC_KEY }}
+            - keyData: {{.Env.PUBLIC_KEY}}
               path: /home/winfv/.ssh/authorized_keys
     storageProfile:
       imageReference:

manifests/canal.yaml

@@ -4,13 +4,13 @@ metadata:
   name: vmss-windows
   namespace: winfv
 spec:
-  location: {{ .Env.AZURE_LOCATION }}
+  location: {{.Env.AZURE_LOCATION}}
   owner:
-    name: {{ .Env.AZURE_RESOURCE_GROUP }}
+    name: {{.Env.AZURE_RESOURCE_GROUP}}
   platformFaultDomainCount: 1
   singlePlacementGroup: false
   sku:
-    capacity: {{ .Env.WINDOWS_NODE_COUNT }}
+    capacity: {{.Env.WINDOWS_NODE_COUNT}}
     name: Standard_D4s_v3
   upgradePolicy:
     mode: Automatic
@@ -51,5 +51,5 @@ spec:
       imageReference:
         publisher: MicrosoftWindowsServer
         offer: WindowsServer
-        sku: {{ .Env.AZURE_WINDOWS_IMAGE_SKU }}
-        version: {{ .Env.AZURE_WINDOWS_IMAGE_VERSION }}
+        sku: {{.Env.AZURE_WINDOWS_IMAGE_SKU}}
+        version: {{.Env.AZURE_WINDOWS_IMAGE_VERSION}}

manifests/flannel-migration/calico.yaml

@@ -7,9 +7,9 @@ spec:
   addressSpace:
     addressPrefixes:
       - 10.0.0.0/16
-  location: {{ .Env.AZURE_LOCATION }}
+  location: {{.Env.AZURE_LOCATION}}
   owner:
-    name: {{ .Env.AZURE_RESOURCE_GROUP }}
+    name: {{.Env.AZURE_RESOURCE_GROUP}}
 
 ---
 apiVersion: network.azure.com/v1api20201101