Skip to content

Pivot facet field list aria roles are incorrect #3559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seanaery opened this issue Apr 4, 2025 · 0 comments
Open

Pivot facet field list aria roles are incorrect #3559

seanaery opened this issue Apr 4, 2025 · 0 comments

Comments

@seanaery
Copy link
Contributor

seanaery commented Apr 4, 2025

This accessibility issue is flagged by Axe DevTools when a Pivot Field is expanded.

<li> elements must be contained in a <ul> or <ol>

https://dequeuniversity.com/rules/axe/4.10/listitem?application=AxeChrome

To solve this problem, you need to fix the following: List item parent element has a role that is not role="list"

It appears the pivot-facet uls currently have role="group" which makes them not semantically treated as lists; and because the lis do not currently have a role, they expect to be members of a list.

If Blacklight core were to follow the same practice as blacklight-hierarchy (which does not have this issue), we'd use role="group" or role="tree" on the uls, and role="treeitem" on the lis for nested facets. See examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant