Fix file name could not be searched if the file was not a text file when using the Bleve indexer (go-gitea#33959)

charles7668 · wxiaoguang · Gusted · commit 9d8624f3413a · 2025-04-01T02:28:02.000+02:00
Close go-gitea#33828 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> (cherry picked from commit b956cee)
diff --git a/modules/indexer/code/bleve/bleve.go b/modules/indexer/code/bleve/bleve.go
@@ -179,7 +179,8 @@ func (b *Indexer) addUpdate(ctx context.Context, batchWriter git.WriteCloserErro
 		return err
 	} else if !typesniffer.DetectContentType(fileContents).IsText() {
 		// FIXME: UTF-16 files will probably fail here
-		return nil
+		// Even if the file is not recognized as a "text file", we could still put its name into the indexers to make the filename become searchable, while leave the content to empty.
+		fileContents = nil
 	}
 
 	if _, err = batchReader.Discard(1); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -179,7 +179,8 @@ func (b *Indexer) addUpdate(ctx context.Context, batchWriter git.WriteCloserErro`
`179`	`179`	`return err`
`180`	`180`	`} else if !typesniffer.DetectContentType(fileContents).IsText() {`
`181`	`181`	`// FIXME: UTF-16 files will probably fail here`
`182`		`- return nil`
	`182`	`+ // Even if the file is not recognized as a "text file", we could still put its name into the indexers to make the filename become searchable, while leave the content to empty.`
	`183`	`+ fileContents = nil`
`183`	`184`	`}`
`184`	`185`
`185`	`186`	`if _, err = batchReader.Discard(1); err != nil {`