Skip to content

JOSS review on documentation - statement of need #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dominiquesydow opened this issue Apr 3, 2022 · 3 comments
Closed

JOSS review on documentation - statement of need #203

dominiquesydow opened this issue Apr 3, 2022 · 3 comments

Comments

@dominiquesydow
Copy link

Hi @wojdyr,

One of the checklist items for my review is the following:

A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?

I could not find this in the documentation, yet. I recommend copying the "Statement of need" section in the paper to the documentation as a subsection under "Introduction" (after the paper has been finalized).

@dominiquesydow
Copy link
Author

Link to the review: openjournals/joss-reviews#4200

@wojdyr
Copy link
Member

wojdyr commented Apr 4, 2022

The audience is mentioned at the very beginning of the introduction https://gemmi.readthedocs.io/en/latest/

primarily for use in macromolecular crystallography [...]
Parts of this library can be useful in structural bioinformatics (for symmetry-aware analysis of protein models), and in other molecular-structure sciences that use CIF files

When reading it myself, it could be reworded and the chemical crystallography could be mentioned explicitly. But I'd rather not compare gemmi with other libraries in the documentation.

@wojdyr
Copy link
Member

wojdyr commented Apr 24, 2022

I reworded minimally the introduction.

@wojdyr wojdyr closed this as completed Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants