Add validation for speed and description (#291)

joyas-joseph · web-flow · commit ed8d2ba29117 · 2019-11-20T11:09:57.000-08:00
* Add validation for speed and description

* Add pattern for alias
diff --git a/models/yang/sonic/sonic-port.yang b/models/yang/sonic/sonic-port.yang
@@ -44,19 +44,28 @@ module sonic-port {
 				}
 
 				leaf speed {
-					type uint64;
+					type uint64 {
+						range "1000|10000|25000|40000|50000|100000|400000" {
+							error-message "Invalid Ethernet interface speed";
+							error-app-tag port-speed-invalid;
+						}
+					}
 				}
 
 				leaf valid_speeds {
 					type string;
 				}
 
 				leaf alias {
-					type string;
+					type string {
+					    pattern '[ -~]{0,64}';
+					}
 				}
 
 				leaf description {
-					type string;
+					type string {
+					    pattern '[ -~]{0,64}';
+					}
 				}
 
 				leaf mtu{

Original file line number	Diff line number	Diff line change
`@@ -44,19 +44,28 @@ module sonic-port {`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`leaf speed {`
`47`		`- type uint64;`
	`47`	`+ type uint64 {`
	`48`	`+ range "1000\|10000\|25000\|40000\|50000\|100000\|400000" {`
	`49`	`+ error-message "Invalid Ethernet interface speed";`
	`50`	`+ error-app-tag port-speed-invalid;`
	`51`	`+ }`
	`52`	`+ }`
`48`	`53`	`}`
`49`	`54`
`50`	`55`	`leaf valid_speeds {`
`51`	`56`	`type string;`
`52`	`57`	`}`
`53`	`58`
`54`	`59`	`leaf alias {`
`55`		`- type string;`
	`60`	`+ type string {`
	`61`	`+ pattern '[ -~]{0,64}';`
	`62`	`+ }`
`56`	`63`	`}`
`57`	`64`
`58`	`65`	`leaf description {`
`59`		`- type string;`
	`66`	`+ type string {`
	`67`	`+ pattern '[ -~]{0,64}';`
	`68`	`+ }`
`60`	`69`	`}`
`61`	`70`
`62`	`71`	`leaf mtu{`