refactor: use node prefix (#9)

privatenumber · web-flow · commit 4ba24d5d7753 · 2024-05-01T18:39:33.000+09:00
diff --git a/src/@types/module.d.ts b/src/@types/module.d.ts
@@ -1,4 +1,4 @@
-import 'module';
+import 'node:module';
 
 declare global {
 	namespace NodeJS {
@@ -8,7 +8,7 @@ declare global {
 	}
 }
 
-declare module 'module' {
+declare module 'node:module' {
 	// https://nodejs.org/api/module.html#loadurl-context-nextload
 	interface LoadHookContext {
 		importAttributes: ImportAssertions;
diff --git a/src/cjs/api/global-require-patch.ts b/src/cjs/api/global-require-patch.ts
@@ -1,4 +1,4 @@
-import Module from 'module';
+import Module from 'node:module';
 import { extensions } from './module-extensions.js';
 import { resolveFilename } from './module-resolve-filename.js';
 
diff --git a/src/cjs/api/module-extensions.ts b/src/cjs/api/module-extensions.ts
@@ -1,5 +1,5 @@
-import fs from 'fs';
-import Module from 'module';
+import fs from 'node:fs';
+import Module from 'node:module';
 import { createFilesMatcher } from 'get-tsconfig';
 import type { TransformOptions } from 'esbuild';
 import { transformSync } from '../../utils/transform/index.js';
diff --git a/src/cjs/api/module-resolve-filename.ts b/src/cjs/api/module-resolve-filename.ts
@@ -1,5 +1,5 @@
-import path from 'path';
-import Module from 'module';
+import path from 'node:path';
+import Module from 'node:module';
 import { createPathsMatcher } from 'get-tsconfig';
 import { resolveTsPath } from '../../utils/resolve-ts-path.js';
 import type { NodeError } from '../../types.js';
diff --git a/src/cjs/api/require.ts b/src/cjs/api/require.ts
@@ -1,4 +1,4 @@
-import path from 'path';
+import path from 'node:path';
 import { fileURLToPath } from 'node:url';
 import { register } from './global-require-patch.js';
 import { resolveFilename } from './module-resolve-filename.js';
diff --git a/src/cjs/api/utils.ts b/src/cjs/api/utils.ts
@@ -1,4 +1,4 @@
-import path from 'path';
+import path from 'node:path';
 import {
 	getTsconfig,
 	parseTsconfig,
diff --git a/src/cli.ts b/src/cli.ts
@@ -1,6 +1,6 @@
-import { constants as osConstants } from 'os';
-import type { ChildProcess, Serializable } from 'child_process';
-import type { Server } from 'net';
+import { constants as osConstants } from 'node:os';
+import type { ChildProcess, Serializable } from 'node:child_process';
+import type { Server } from 'node:net';
 import { cli } from 'cleye';
 import {
 	transformSync as esbuildTransformSync,
diff --git a/src/esm/hook/index.ts b/src/esm/hook/index.ts
@@ -1,4 +1,4 @@
-import type { GlobalPreloadHook, InitializeHook } from 'module';
+import type { GlobalPreloadHook, InitializeHook } from 'node:module';
 
 export const initialize: InitializeHook = async (data) => {
 	if (!data) {
diff --git a/src/esm/hook/load.ts b/src/esm/hook/load.ts
@@ -1,5 +1,5 @@
-import { fileURLToPath } from 'url';
-import type { LoadHook } from 'module';
+import { fileURLToPath } from 'node:url';
+import type { LoadHook } from 'node:module';
 import type { TransformOptions } from 'esbuild';
 import { transform } from '../../utils/transform/index.js';
 import { transformDynamicImport } from '../../utils/transform/transform-dynamic-import.js';
diff --git a/src/esm/hook/package-json.ts b/src/esm/hook/package-json.ts
@@ -1,5 +1,5 @@
-import fs from 'fs';
-import { fileURLToPath } from 'url';
+import fs from 'node:fs';
+import { fileURLToPath } from 'node:url';
 import type { PackageJson } from 'type-fest';
 
 const packageJsonCache = new Map<string, PackageJson | undefined>();
diff --git a/src/esm/hook/resolve.ts b/src/esm/hook/resolve.ts
@@ -1,8 +1,8 @@
-import path from 'path';
-import { pathToFileURL } from 'url';
+import path from 'node:path';
+import { pathToFileURL } from 'node:url';
 import type {
 	ResolveFnOutput, ResolveHookContext,
-} from 'module';
+} from 'node:module';
 import { resolveTsPath } from '../../utils/resolve-ts-path.js';
 import type { NodeError } from '../../types.js';
 import { isRelativePathPattern } from '../../utils/is-relative-path-pattern.js';
diff --git a/src/esm/hook/utils.ts b/src/esm/hook/utils.ts
@@ -1,5 +1,5 @@
-import path from 'path';
-import type { ModuleFormat } from 'module';
+import path from 'node:path';
+import type { ModuleFormat } from 'node:module';
 import {
 	getTsconfig,
 	parseTsconfig,
diff --git a/src/patch-repl.ts b/src/patch-repl.ts
@@ -1,4 +1,4 @@
-import repl, { type REPLServer, type REPLEval } from 'repl';
+import repl, { type REPLServer, type REPLEval } from 'node:repl';
 import { transform } from 'esbuild';
 
 const patchEval = (nodeRepl: REPLServer) => {
diff --git a/src/preflight.cts b/src/preflight.cts
@@ -1,4 +1,4 @@
-import { constants as osConstants } from 'os';
+import { constants as osConstants } from 'node:os';
 import { isMainThread } from 'node:worker_threads';
 import { connectingToServer } from './utils/ipc/client.js';
 import './suppress-warnings.cjs';
diff --git a/src/repl.ts b/src/repl.ts
@@ -1,6 +1,6 @@
 // Deprecated: Delete entry-point in next major in favor of patch-repl.ts
 
-import repl, { type REPLEval } from 'repl';
+import repl, { type REPLEval } from 'node:repl';
 import { version } from '../package.json';
 import { transform } from './utils/transform/index.js';
 
diff --git a/src/run.ts b/src/run.ts
@@ -1,5 +1,5 @@
-import type { StdioOptions } from 'child_process';
-import { pathToFileURL } from 'url';
+import type { StdioOptions } from 'node:child_process';
+import { pathToFileURL } from 'node:url';
 import spawn from 'cross-spawn';
 import { isFeatureSupported, moduleRegister } from './utils/node-features';
 
diff --git a/src/utils/ipc/client.ts b/src/utils/ipc/client.ts
@@ -1,4 +1,4 @@
-import net from 'net';
+import net from 'node:net';
 import { getPipePath } from './get-pipe-path.js';
 
 export type SendToParent = (data: Record<string, unknown>) => void;
diff --git a/src/utils/ipc/get-pipe-path.ts b/src/utils/ipc/get-pipe-path.ts
@@ -1,4 +1,4 @@
-import path from 'path';
+import path from 'node:path';
 import { tmpdir } from '../temporary-directory.js';
 import { isWindows } from '../is-windows.js';
 
diff --git a/src/utils/ipc/server.ts b/src/utils/ipc/server.ts
@@ -1,5 +1,5 @@
-import net from 'net';
-import fs from 'fs';
+import net from 'node:net';
+import fs from 'node:fs';
 import { tmpdir } from '../temporary-directory.js';
 import { isWindows } from '../is-windows.js';
 import { getPipePath } from './get-pipe-path.js';
diff --git a/src/utils/read-json-file.ts b/src/utils/read-json-file.ts
@@ -1,4 +1,4 @@
-import fs from 'fs';
+import fs from 'node:fs';
 
 export const readJsonFile = <JsonType>(
 	filePath: string,
diff --git a/src/utils/resolve-ts-path.ts b/src/utils/resolve-ts-path.ts
@@ -1,4 +1,4 @@
-import path from 'path';
+import path from 'node:path';
 
 const tsExtensions: Record<string, string[]> = Object.create(null);
 tsExtensions['.js'] = ['.ts', '.tsx', '.js', '.jsx'];
diff --git a/src/utils/sha1.ts b/src/utils/sha1.ts
@@ -1,4 +1,4 @@
-import crypto from 'crypto';
+import crypto from 'node:crypto';
 
 export const sha1 = (data: string) => (
 	crypto
diff --git a/src/utils/temporary-directory.ts b/src/utils/temporary-directory.ts
@@ -1,5 +1,5 @@
-import path from 'path';
-import os from 'os';
+import path from 'node:path';
+import os from 'node:os';
 
 /**
  * Cache directory is based on the user's identifier
diff --git a/src/utils/transform/cache.ts b/src/utils/transform/cache.ts
@@ -1,6 +1,6 @@
-import fs from 'fs';
-import path from 'path';
-import os from 'os';
+import fs from 'node:fs';
+import path from 'node:path';
+import os from 'node:os';
 import { readJsonFile } from '../read-json-file.js';
 import { tmpdir } from '../temporary-directory.js';
 import type { Transformed } from './apply-transformers.js';
diff --git a/src/utils/transform/get-esbuild-options.ts b/src/utils/transform/get-esbuild-options.ts
@@ -1,4 +1,4 @@
-import path from 'path';
+import path from 'node:path';
 import type { TransformOptions, TransformResult } from 'esbuild';
 import type { SourceMap } from '@ampproject/remapping';
 
diff --git a/src/utils/transform/index.ts b/src/utils/transform/index.ts
@@ -1,4 +1,4 @@
-import { pathToFileURL } from 'url';
+import { pathToFileURL } from 'node:url';
 import {
 	transform as esbuildTransform,
 	transformSync as esbuildTransformSync,
diff --git a/src/watch/index.ts b/src/watch/index.ts
@@ -1,7 +1,7 @@
-import type { ChildProcess } from 'child_process';
-import { fileURLToPath } from 'url';
-import { constants as osConstants } from 'os';
-import path from 'path';
+import type { ChildProcess } from 'node:child_process';
+import { fileURLToPath } from 'node:url';
+import { constants as osConstants } from 'node:os';
+import path from 'node:path';
 import { command } from 'cleye';
 import { watch } from 'chokidar';
 import { lightMagenta, lightGreen, yellow } from 'kolorist';
diff --git a/tests/specs/api.ts b/tests/specs/api.ts
@@ -1,4 +1,4 @@
-import path from 'path';
+import path from 'node:path';
 import { execaNode } from 'execa';
 import { testSuite, expect } from 'manten';
 import { createFixture } from 'fs-fixture';
@@ -114,11 +114,11 @@ export default testSuite(({ describe }, node: NodeApis) => {
 			});
 		});
 
-		describe('Module', ({ test }) => {
+		describe('node:module', ({ test }) => {
 			if (node.supports.moduleRegister) {
 				test('module.register', async ({ onTestFinish }) => {
 					const fixture = await createFixture({
-						'package.json': JSON.stringify({ type: 'module' }),
+						'package.json': JSON.stringify({ type: 'node:module' }),
 						'module-register.mjs': `
 						import { register } from 'node:module';
 
diff --git a/tests/specs/cli.ts b/tests/specs/cli.ts
@@ -1,4 +1,4 @@
-import path from 'path';
+import path from 'node:path';
 import { setTimeout } from 'timers/promises';
 import { testSuite, expect } from 'manten';
 import { createFixture } from 'fs-fixture';
diff --git a/tests/specs/loaders.ts b/tests/specs/loaders.ts
@@ -9,12 +9,12 @@ export default testSuite(({ describe }, node: NodeApis) => {
 				'package.json': JSON.stringify({ type: 'module' }),
 
 				'ts.ts': `
-				import fs from 'fs';
+				import fs from 'node:fs';
 
 				console.log(Boolean(fs) as unknown as string);
 				`,
 				'mts.mts': `
-				import fs from 'fs';
+				import fs from 'node:fs';
 
 				console.log(JSON.stringify([Boolean(fs) as unknown as string, import.meta.url]));
 				`,
@@ -53,17 +53,17 @@ export default testSuite(({ describe }, node: NodeApis) => {
 				'package.json': JSON.stringify({ type: 'commonjs' }),
 
 				'ts.ts': `
-				import fs from 'fs';
+				import fs from 'node:fs';
 
 				console.log(Boolean(fs) as unknown as string);
 				`,
 				'cts.cts': `
-				import fs from 'fs';
+				import fs from 'node:fs';
 
 				console.log(Boolean(fs) as unknown as string);
 				`,
 				'mts.mts': `
-				import fs from 'fs';
+				import fs from 'node:fs';
 
 				console.log(Boolean(fs) as unknown as string, import.meta.url);
 				`,
diff --git a/tests/specs/smoke.ts b/tests/specs/smoke.ts
@@ -1,5 +1,5 @@
-import path from 'path';
-import { pathToFileURL } from 'url';
+import path from 'node:path';
+import { pathToFileURL } from 'node:url';
 import { testSuite, expect } from 'manten';
 import { createFixture } from 'fs-fixture';
 import outdent from 'outdent';
@@ -82,7 +82,7 @@ const sourcemap = {
 	// Adding the dynamic import helps test the import transformation's source map
 	test: (
 		extension: string,
-	) => `import('fs');\nconst { stack } = new Error(); const searchString = 'index.${extension}:SOURCEMAP_LINE'; assert(stack.includes(searchString), \`Expected \${searchString} in stack: \${stack}\`)`,
+	) => `import('node:fs');\nconst { stack } = new Error(); const searchString = 'index.${extension}:SOURCEMAP_LINE'; assert(stack.includes(searchString), \`Expected \${searchString} in stack: \${stack}\`)`,
 	tag: (
 		strings: TemplateStringsArray,
 		...values: string[]
diff --git a/tests/specs/watch.ts b/tests/specs/watch.ts
@@ -1,4 +1,4 @@
-import path from 'path';
+import path from 'node:path';
 import { setTimeout } from 'timers/promises';
 import { testSuite, expect } from 'manten';
 import { createFixture } from 'fs-fixture';
diff --git a/tests/utils/pty-shell/index.ts b/tests/utils/pty-shell/index.ts
@@ -1,5 +1,5 @@
 import { setTimeout } from 'timers/promises';
-import { fileURLToPath } from 'url';
+import { fileURLToPath } from 'node:url';
 import { execaNode, type NodeOptions } from 'execa';
 import stripAnsi from 'strip-ansi';
 import split from 'split2';
diff --git a/tests/utils/tsx.ts b/tests/utils/tsx.ts
@@ -1,4 +1,4 @@
-import { fileURLToPath } from 'url';
+import { fileURLToPath } from 'node:url';
 import { execaNode, type NodeOptions } from 'execa';
 import getNode from 'get-node';
 import {

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import 'module';`
	`1`	`+import 'node:module';`
`2`	`2`
`3`	`3`	`declare global {`
`4`	`4`	`namespace NodeJS {`
`@@ -8,7 +8,7 @@ declare global {`
`8`	`8`	`}`
`9`	`9`	`}`
`10`	`10`
`11`		`-declare module 'module' {`
	`11`	`+declare module 'node:module' {`
`12`	`12`	`// https://nodejs.org/api/module.html#loadurl-context-nextload`
`13`	`13`	`interface LoadHookContext {`
`14`	`14`	`importAttributes: ImportAssertions;`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import Module from 'module';`
	`1`	`+import Module from 'node:module';`
`2`	`2`	`import { extensions } from './module-extensions.js';`
`3`	`3`	`import { resolveFilename } from './module-resolve-filename.js';`
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import path from 'path';`
	`1`	`+import path from 'node:path';`
`2`	`2`	`import { fileURLToPath } from 'node:url';`
`3`	`3`	`import { register } from './global-require-patch.js';`
`4`	`4`	`import { resolveFilename } from './module-resolve-filename.js';`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import type { GlobalPreloadHook, InitializeHook } from 'module';`
	`1`	`+import type { GlobalPreloadHook, InitializeHook } from 'node:module';`
`2`	`2`
`3`	`3`	`export const initialize: InitializeHook = async (data) => {`
`4`	`4`	`if (!data) {`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import repl, { type REPLServer, type REPLEval } from 'repl';`
	`1`	`+import repl, { type REPLServer, type REPLEval } from 'node:repl';`
`2`	`2`	`import { transform } from 'esbuild';`
`3`	`3`
`4`	`4`	`const patchEval = (nodeRepl: REPLServer) => {`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { constants as osConstants } from 'os';`
	`1`	`+import { constants as osConstants } from 'node:os';`
`2`	`2`	`import { isMainThread } from 'node:worker_threads';`
`3`	`3`	`import { connectingToServer } from './utils/ipc/client.js';`
`4`	`4`	`import './suppress-warnings.cjs';`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import net from 'net';`
	`1`	`+import net from 'node:net';`
`2`	`2`	`import { getPipePath } from './get-pipe-path.js';`
`3`	`3`
`4`	`4`	`export type SendToParent = (data: Record<string, unknown>) => void;`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import fs from 'fs';`
	`1`	`+import fs from 'node:fs';`
`2`	`2`
`3`	`3`	`export const readJsonFile = <JsonType>(`
`4`	`4`	`filePath: string,`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import crypto from 'crypto';`
	`1`	`+import crypto from 'node:crypto';`
`2`	`2`
`3`	`3`	`export const sha1 = (data: string) => (`
`4`	`4`	`crypto`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { pathToFileURL } from 'url';`
	`1`	`+import { pathToFileURL } from 'node:url';`
`2`	`2`	`import {`
`3`	`3`	`transform as esbuildTransform,`
`4`	`4`	`transformSync as esbuildTransformSync,`