Skip to content

Commit 507a743

Browse files
authored
Explicitly convert params to integers where needed in previews (#2735)
1 parent 6fe410b commit 507a743

File tree

7 files changed

+15
-10
lines changed

7 files changed

+15
-10
lines changed

.changeset/dirty-parents-sneeze.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@primer/view-components": patch
3+
---
4+
5+
Explicitly convert params to integers where needed for several previews

previews/primer/alpha/tab_nav_preview.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ class TabNavPreview < ViewComponent::Preview
1111
# @param with_counters [Boolean] toggle
1212
def playground(number_of_tabs: 3, with_icons: false, with_counters: false)
1313
render(Primer::Alpha::TabNav.new(label: "label")) do |component|
14-
Array.new(number_of_tabs || 3) do |i|
14+
Array.new(number_of_tabs&.to_i || 3) do |i|
1515
component.with_tab(selected: i.zero?, href: "##{i + 1}") do |tab|
1616
tab.with_icon(icon: :star) if with_icons
1717
tab.with_text { "Tab #{i + 1}" }

previews/primer/alpha/tab_panels_preview.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ class TabPanelsPreview < ViewComponent::Preview
1010
# @param align [Symbol] select [left, right]
1111
def playground(number_of_panels: 3, align: :left)
1212
render(Primer::Alpha::TabPanels.new(label: "label", align: align)) do |component|
13-
Array.new(number_of_panels || 3) do |i|
13+
Array.new(number_of_panels&.to_i || 3) do |i|
1414
component.with_tab(selected: i.zero?, id: "tab-#{i + 1}") do |tab|
1515
tab.with_panel { "Panel #{i + 1}" }
1616
tab.with_text { "Tab #{i + 1}" }
@@ -26,7 +26,7 @@ def playground(number_of_panels: 3, align: :left)
2626
# @snapshot
2727
def default(number_of_panels: 3, align: :left)
2828
render(Primer::Alpha::TabPanels.new(label: "label", align: align)) do |component|
29-
Array.new(number_of_panels || 3) do |i|
29+
Array.new(number_of_panels&.to_i || 3) do |i|
3030
component.with_tab(selected: i.zero?, id: "tab-#{i + 1}") do |tab|
3131
tab.with_panel { "Panel #{i + 1}" }
3232
tab.with_text { "Tab #{i + 1}" }

previews/primer/alpha/underline_nav_preview.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ def playground(label: "Default with nav element", tag: :nav, align: :left, numbe
1515
label: label,
1616
tag: tag,
1717
align: align,
18-
number_of_panels: number_of_panels
18+
number_of_panels: number_of_panels.to_i,
1919
})
2020
end
2121

@@ -31,7 +31,7 @@ def default(label: "Default with nav element", tag: :nav, align: :left, number_o
3131
label: label,
3232
tag: tag,
3333
align: align,
34-
number_of_panels: number_of_panels
34+
number_of_panels: number_of_panels.to_i,
3535
})
3636
end
3737

@@ -44,7 +44,7 @@ def default(label: "Default with nav element", tag: :nav, align: :left, number_o
4444
# @param number_of_panels [Integer] number
4545
def with_icons_and_counters(label: "With icons and counters", number_of_panels: 3, align: :left, tag: :nav)
4646
render(Primer::Alpha::UnderlineNav.new(label: label, tag: tag, align: align)) do |component|
47-
Array.new(number_of_panels || 3) do |i|
47+
Array.new(number_of_panels.to_i || 3) do |i|
4848
component.with_tab(href: "#", selected: i.zero?) do |tab|
4949
tab.with_icon(icon: :star)
5050
tab.with_text { "Item #{i + 1}" }

previews/primer/alpha/underline_panels_preview.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def playground(number_of_panels: 3, align: :left)
2626
# @param align [Symbol] select [left, right]
2727
def default(number_of_panels: 3, align: :left)
2828
render(Primer::Alpha::UnderlinePanels.new(label: "Test navigation", align: align)) do |component|
29-
Array.new(number_of_panels || 3) do |i|
29+
Array.new(number_of_panels&.to_i || 3) do |i|
3030
component.with_tab(selected: i.zero?, id: "tab-#{i + 1}") do |tab|
3131
tab.with_panel { "Panel #{i + 1}" }
3232
tab.with_text { "Tab #{i + 1}" }

previews/primer/beta/avatar_stack_preview.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class AvatarStackPreview < ViewComponent::Preview
1313
# @param tooltip_label text
1414
def playground(number_of_avatars: 1, tag: :div, align: :left, tooltipped: false, tooltip_label: "This is a tooltip!")
1515
render(Primer::Beta::AvatarStack.new(tag: tag, align: align, tooltipped: tooltipped, body_arguments: { label: tooltip_label })) do |component|
16-
Array.new(number_of_avatars || 1) do
16+
Array.new(number_of_avatars&.to_i || 1) do
1717
component.with_avatar(src: Primer::ExampleImage::BASE64_SRC, alt: "@kittenuser")
1818
end
1919
end

previews/primer/beta/breadcrumbs_preview.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ class BreadcrumbsPreview < ViewComponent::Preview
99
# @param number_of_links [Integer] number
1010
def playground(number_of_links: 2)
1111
render(Primer::Beta::Breadcrumbs.new) do |component|
12-
Array.new(number_of_links || 3) do |i|
12+
Array.new(number_of_links&.to_i || 3) do |i|
1313
component.with_item(href: "##{i}") { "Breadcrumb Item #{i + 1}" }
1414
end
1515
end
@@ -21,7 +21,7 @@ def playground(number_of_links: 2)
2121
# @snapshot
2222
def default(number_of_links: 2)
2323
render(Primer::Beta::Breadcrumbs.new) do |component|
24-
Array.new(number_of_links || 3) do |i|
24+
Array.new(number_of_links&.to_i || 3) do |i|
2525
component.with_item(href: "##{i}") { "Breadcrumb Item #{i + 1}" }
2626
end
2727
end

0 commit comments

Comments
 (0)