Skip to content

Commit 18d5f21

Browse files
authored
fix: Allow Breadcrumb items to wrap (#2869)
Co-authored-by: smockle <[email protected]>
1 parent bbefd41 commit 18d5f21

File tree

9 files changed

+46
-1
lines changed

9 files changed

+46
-1
lines changed

.changeset/tiny-penguins-roll.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@primer/view-components': patch
3+
---
4+
5+
fix: Allow breadcrumb items to wrap.

app/components/primer/beta/breadcrumbs.pcss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
.breadcrumb-item {
22
display: inline-block;
33
margin-left: -0.35em;
4-
white-space: nowrap;
54
list-style: none;
65

76
&::after {

previews/primer/beta/breadcrumbs_preview.rb

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,18 @@ def default(number_of_links: 2)
2626
end
2727
end
2828
end
29+
30+
# @label WithBetaTruncate
31+
# @snapshot
32+
def with_beta_truncate
33+
render_with_template
34+
end
35+
36+
# @label WithDeprecatedTruncate
37+
# @snapshot
38+
def with_deprecated_truncate
39+
render_with_template
40+
end
2941
end
3042
end
3143
end
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
<% texts = [
2+
"Breadcrumb Item 1",
3+
"Breadcrumb Item 2 with a really long, long, long name",
4+
"Breadcrumb Item 3 with an extremely long, long, long name"
5+
] %>
6+
7+
<%= render(Primer::Beta::Breadcrumbs.new) do |breadcrumbs| %>
8+
<% texts.each_with_index do |text, i| %>
9+
<% breadcrumbs.with_item(href: "##{i}") do %>
10+
<%= render(Primer::Beta::Truncate.new) do |truncate| %>
11+
<% truncate.with_item(max_width: 135) { text } %>
12+
<% end %>
13+
<% end %>
14+
<% end %>
15+
<% end %>
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
<%# erblint:counter DeprecatedComponentsCounter 1 %>
2+
<% texts = [
3+
"Breadcrumb Item 1",
4+
"Breadcrumb Item 2 with a really long, long, long name",
5+
"Breadcrumb Item 3 with an extremely long, long, long name"
6+
] %>
7+
8+
<%= render(Primer::Beta::Breadcrumbs.new) do |breadcrumbs| %>
9+
<% texts.each_with_index do |text, i| %>
10+
<% breadcrumbs.with_item(href: "##{i}") do %>
11+
<%= render(Primer::Truncate.new(inline: true, max_width: 135)) { text } %>
12+
<% end %>
13+
<% end %>
14+
<% end %>

0 commit comments

Comments
 (0)