Skip to content

Commit ed31476

Browse files
authored
feat(FeatureFlags): broaden feature flag type to accept undefined (#4554)
* feat(FeatureFlags): loosen feature flag type to accept undefined * chore: add changeset * Update .changeset/grumpy-coats-worry.md --------- Co-authored-by: Josh Black <[email protected]>
1 parent e094a39 commit ed31476

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

.changeset/grumpy-coats-worry.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@primer/react': minor
3+
---
4+
5+
Broaden feature flag type for experimental FeatureFlags to accept undefined

packages/react/src/FeatureFlags/FeatureFlagScope.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
export type FeatureFlags = {
2-
[key: string]: boolean
2+
[key: string]: boolean | undefined
33
}
44

55
export class FeatureFlagScope {
@@ -24,7 +24,10 @@ export class FeatureFlagScope {
2424
flags: Map<string, boolean>
2525

2626
constructor(flags: FeatureFlags = {}) {
27-
this.flags = new Map(Object.entries(flags))
27+
this.flags = new Map()
28+
for (const [key, value] of Object.entries(flags)) {
29+
this.flags.set(key, value ?? false)
30+
}
2831
}
2932

3033
/**

0 commit comments

Comments
 (0)