You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
### 3. Add or update SVG files in the `/icons` directory
64
+
####3. Add or update SVG files in the `/icons` directory
63
65
64
-
### 4. Add or update keywords in `keywords.json`
66
+
####4. Add or update keywords in `keywords.json`
65
67
66
68
```diff
67
69
{
@@ -70,20 +72,45 @@ git checkout -b <branch-name>
70
72
}
71
73
```
72
74
73
-
### 5. Commit and push changes
75
+
####5. Commit and push changes
74
76
75
77
```shell
76
78
git add .
77
79
git commit -m <message>
78
80
git push
79
81
```
80
82
81
-
### 6. Create a pull request
83
+
####6. Create a pull request
82
84
83
85
Use GitHub to [create a pull request](https://help.github.com/en/desktop/contributing-to-projects/creating-a-pull-request) for your branch. In your pull request description, be sure to mention where the icon will be used and any relevant timeline information.
84
86
85
87
If everything looks good, a maintainer will approve and merge the pull request when appropriate. After the pull request is merged, your icon will be available in the next Octicons release.
86
88
89
+
### Using the Octicons Push Figma plugin
90
+
91
+
If you work at GitHub, you can use the [Octicons Push](https://www.figma.com/community/plugin/825432045044458754/Octicons-Push) Figma plugin to start an Octicons pull request from Figma.
92
+
93
+
Here's how it works:
94
+
95
+
1. Select the icon frames you want to commit. Make sure the frames are either 16x16 or 24x24 and that you've outlined all strokes.
96
+
2. Open the Octicons Push plugin.
97
+
3. Select the branch you want to commit to. You can choose an existing branch or create a new branch.
98
+
4. Press "Commit." The plugin will then export, commit, and push the selected icons to the branch you chose. If you chose to create a new branch, the plugin will give you a link to where you can start a new pull request with your branch.
99
+
100
+
After you create a pull request, a member of the Design Infrastructure team will triage and review your contribution.
101
+
102
+

103
+
104
+
## How changes are reviewed
105
+
106
+
Here are a few questions we'll ask when reviewing new octicons. Keep these in mind as you're designing:
107
+
108
+
- Where will this icon be used in the context of GitHub UI?
109
+
- Is an icon necessary in that context?
110
+
- Could we use an existing icon?
111
+
- Is the icon trying to represent too many ideas?
112
+
- Does it follow the design guidelines?
113
+
87
114
## Releasing changes
88
115
89
116
Once submitted changes have been agreed upon, these instructions will guide maintainers through releasing changes.
0 commit comments