Skip to content

Commit 0d1b1ff

Browse files
gavinmnactions-usercolebemis
authored
Add Goal icons (#873)
* Save goal-16.svg, goal-24.svg * Optimize SVGs * Create selfish-pianos-talk.md * Save goal-16.svg, goal-24.svg * Optimize SVGs * Fix ruby job * Fix all ruby jobs * Update api snapshot Co-authored-by: Gavin Nelson <[email protected]> Co-authored-by: Cole Bemis <[email protected]>
1 parent c1e4350 commit 0d1b1ff

File tree

5 files changed

+56
-48
lines changed

5 files changed

+56
-48
lines changed

‎.changeset/selfish-pianos-talk.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@primer/octicons": minor
3+
---
4+
5+
Add Goal icons

‎.github/workflows/ci.yml

+48-48
Original file line numberDiff line numberDiff line change
@@ -97,26 +97,26 @@ jobs:
9797
run:
9898
working-directory: ./lib/octicons_gem
9999
steps:
100-
- uses: actions/checkout@v2
101-
- name: Setup Ruby
102-
uses: actions/setup-ruby@v1
103-
with:
104-
ruby-version: 2.7
105-
- uses: actions/download-artifact@v2
106-
with:
107-
name: octicons-build
108-
path: ./lib/octicons_gem/lib/build
109-
- run: bundle install
110-
- name: Linting
111-
run: bundle exec rake lint
112-
- name: Testing
113-
run: bundle exec rake test
114-
- name: Build
115-
run: bundle exec rake build
116-
- uses: actions/upload-artifact@master
117-
with:
118-
name: octicons-gem
119-
path: ./lib/octicons_gem/pkg
100+
- uses: actions/checkout@v2
101+
- name: Setup Ruby
102+
uses: ruby/setup-ruby@v1
103+
with:
104+
ruby-version: 2.7
105+
- uses: actions/download-artifact@v2
106+
with:
107+
name: octicons-build
108+
path: ./lib/octicons_gem/lib/build
109+
- run: bundle install
110+
- name: Linting
111+
run: bundle exec rake lint
112+
- name: Testing
113+
run: bundle exec rake test
114+
- name: Build
115+
run: bundle exec rake build
116+
- uses: actions/upload-artifact@master
117+
with:
118+
name: octicons-gem
119+
path: ./lib/octicons_gem/pkg
120120

121121
octicons_helper:
122122
name: 'gem:octicons_helper'
@@ -126,20 +126,20 @@ jobs:
126126
run:
127127
working-directory: ./lib/octicons_helper
128128
steps:
129-
- uses: actions/checkout@v2
130-
- name: Setup Ruby
131-
uses: actions/setup-ruby@v1
132-
with:
133-
ruby-version: 2.7
134-
- uses: actions/download-artifact@v2
135-
with:
136-
name: octicons-gem
137-
path: ./lib/octicons_helper/vendor/cache
138-
- run: bundle install
139-
- name: Linting
140-
run: bundle exec rake lint
141-
- name: Testing
142-
run: bundle exec rake test
129+
- uses: actions/checkout@v2
130+
- name: Setup Ruby
131+
uses: ruby/setup-ruby@v1
132+
with:
133+
ruby-version: 2.7
134+
- uses: actions/download-artifact@v2
135+
with:
136+
name: octicons-gem
137+
path: ./lib/octicons_helper/vendor/cache
138+
- run: bundle install
139+
- name: Linting
140+
run: bundle exec rake lint
141+
- name: Testing
142+
run: bundle exec rake test
143143

144144
octicons_jekyll:
145145
name: 'gem:octicons_jekyll'
@@ -149,17 +149,17 @@ jobs:
149149
run:
150150
working-directory: ./lib/octicons_jekyll
151151
steps:
152-
- uses: actions/checkout@v2
153-
- name: Setup Ruby
154-
uses: actions/setup-ruby@v1
155-
with:
156-
ruby-version: 2.7
157-
- uses: actions/download-artifact@v2
158-
with:
159-
name: octicons-gem
160-
path: ./lib/octicons_jekyll/vendor/cache
161-
- run: bundle install
162-
- name: Linting
163-
run: bundle exec rake lint
164-
- name: Testing
165-
run: bundle exec rake test
152+
- uses: actions/checkout@v2
153+
- name: Setup Ruby
154+
uses: ruby/setup-ruby@v1
155+
with:
156+
ruby-version: 2.7
157+
- uses: actions/download-artifact@v2
158+
with:
159+
name: octicons-gem
160+
path: ./lib/octicons_jekyll/vendor/cache
161+
- run: bundle install
162+
- name: Linting
163+
run: bundle exec rake lint
164+
- name: Testing
165+
run: bundle exec rake test

‎icons/goal-16.svg

+1
Loading

‎icons/goal-24.svg

+1
Loading

‎lib/octicons_react/__tests__/__snapshots__/public-api.test.js.snap

+1
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@ exports[`@primer/octicons-react should not update exports without a semver chang
133133
"GitPullRequestDraftIcon",
134134
"GitPullRequestIcon",
135135
"GlobeIcon",
136+
"GoalIcon",
136137
"GrabberIcon",
137138
"GraphIcon",
138139
"HashIcon",

0 commit comments

Comments
 (0)