Skip to content

Dockerfile go version #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
didil opened this issue Jul 29, 2019 · 4 comments
Closed

Dockerfile go version #981

didil opened this issue Jul 29, 2019 · 4 comments
Assignees
@mansinahar
Labels
stale

Comments

@didil
Copy link
Contributor

didil commented Jul 29, 2019

Is there any particular reason why the Go version used in Dockerfile is 1.11.x and not the latest 1.12.x ?
@mansinahar mansinahar self-assigned this Jul 29, 2019
@mansinahar
Copy link
Contributor

I believe it was because there was a bug noted for Go 1.12 in Ubuntu as mentioned here: https://github.com/golang/go/wiki/Ubuntu/f174c92b5fd2dd25c2571cea522f8d2b5b348921#bug-noted-in-ubuntu-golang-112-go-release but looks like it has now been resolved. @didil Would you wanna go ahead and open up a PR for 1.12?

@didil
Copy link
Contributor Author

didil commented Jul 29, 2019

great ill open a PR tomorrow then

@mansinahar
Copy link
Contributor

Cool. Thanks @didil!

@didil didil mentioned this issue Jul 30, 2019
Merged
@stale
Copy link

stale bot commented Aug 8, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mansinahar mansinahar

Labels
stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@didil @mansinahar