Skip to content

Commit f0d2976

Browse files
Gus CarreonGus Carreon
authored andcommitted
Small changes after Mansi's review
1 parent 36e4a6a commit f0d2976

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

pbsmetrics/config/metrics.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ func (me *MultiMetricsEngine) RecordConnectionClose(success bool) {
8383
}
8484
}
8585

86-
// RecordImps across openRTB2 engines that support the 'Native' Imp type
86+
//RecordsImps records imps with imp types across all metric engines
8787
func (me *MultiMetricsEngine) RecordImps(implabels pbsmetrics.ImpLabels) {
8888
for _, thisME := range *me {
8989
thisME.RecordImps(implabels)

pbsmetrics/prometheus/prometheus.go

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -486,15 +486,6 @@ func requestTypesAsString() []string {
486486
return output
487487
}
488488

489-
func impTypesAsString() []string {
490-
list := pbsmetrics.ImpTypes()
491-
output := make([]string, len(list))
492-
for i, s := range list {
493-
output[i] = string(s)
494-
}
495-
return output
496-
}
497-
498489
func browserTypesAsString() []string {
499490
list := pbsmetrics.BrowserTypes()
500491
output := make([]string, len(list))

0 commit comments

Comments
 (0)