Skip to content

Commit 88b354e

Browse files
committed
Exclude Disabled Bidders + Add Unit Test
1 parent c1aab3f commit 88b354e

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

config/bidderinfo.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,10 +88,12 @@ func (r infoReaderFromDisk) Read(bidder string) ([]byte, error) {
8888
return ioutil.ReadFile(path)
8989
}
9090

91+
// ToGVLVendorIDMap transforms a BidderInfos object to a map of bidder name to GVL id. Disabled
92+
// bidders are omitted from the result.
9193
func (infos BidderInfos) ToGVLVendorIDMap() map[openrtb_ext.BidderName]uint16 {
9294
m := make(map[openrtb_ext.BidderName]uint16, len(infos))
9395
for name, info := range infos {
94-
if info.GVLVendorID != 0 {
96+
if info.Enabled && info.GVLVendorID != 0 {
9597
m[openrtb_ext.BidderName(name)] = info.GVLVendorID
9698
}
9799
}

config/bidderinfo_test.go

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,3 +192,19 @@ type fakeInfoReader struct {
192192
func (r fakeInfoReader) Read(bidder string) ([]byte, error) {
193193
return []byte(r.content), r.err
194194
}
195+
196+
func TestToGVLVendorIDMap(t *testing.T) {
197+
givenBidderInfos := BidderInfos{
198+
"bidderA": BidderInfo{Enabled: true, GVLVendorID: 0},
199+
"bidderB": BidderInfo{Enabled: true, GVLVendorID: 100},
200+
"bidderC": BidderInfo{Enabled: false, GVLVendorID: 0},
201+
"bidderD": BidderInfo{Enabled: false, GVLVendorID: 200},
202+
}
203+
204+
expectedGVLVendorIDMap := map[openrtb_ext.BidderName]uint16{
205+
"bidderB": 100,
206+
}
207+
208+
result := givenBidderInfos.ToGVLVendorIDMap()
209+
assert.Equal(t, expectedGVLVendorIDMap, result)
210+
}

0 commit comments

Comments
 (0)