Addressed code review comments given by SyntaxNode.

Also Moved RequestHeaders next to RequestBidy in openrtb_ext.ExtHttpCall

Author: pm-shriprasad-marathe

exchange/bidder_test.go

@@ -886,7 +886,7 @@ func TestBadRequestLogging(t *testing.T) {
 	if ext.Status != 0 {
 		t.Errorf("The Status code should be 0. Got %d", ext.Status)
 	}
-	if nil != ext.RequestHeaders || len(ext.RequestHeaders) > 0 {
+	if len(ext.RequestHeaders) > 0 {
 		t.Errorf("The request headers should be empty. Got %s", ext.RequestHeaders)
 	}
 }

exchange/exchangetest/request-multi-bidders-debug-info.json

@@ -95,9 +95,9 @@
           {
             "uri": "audienceNetworkTest.com",
             "requestbody": "audienceNetworkTestRequestBody",
+            "requestheaders": null,
             "responsebody": "audienceNetworkTestResponseBody",
-            "status": 200,
-            "requestheaders": null
+            "status": 200
           }
         ]
       }
@@ -151,18 +151,18 @@
             {
               "uri": "appnexusTest.com",
               "requestbody": "appnexusTestRequestBody",
+              "requestheaders": { "header_1" : ["value_11", "value_12"], "header_2" : ["value_21"] },
               "responsebody": "appnexusTestResponseBody",
-              "status": 200,
-              "requestheaders": { "header_1" : ["value_11", "value_12"], "header_2" : ["value_21"] }
+              "status": 200
             }
           ],
           "audienceNetwork": [
             {
               "uri": "audienceNetworkTest.com",
               "requestbody": "audienceNetworkTestRequestBody",
+              "requestheaders": null,
               "responsebody": "audienceNetworkTestResponseBody",
-              "status": 200,
-              "requestheaders": null
+              "status": 200
             }
           ]
         },

openrtb_ext/response.go

@@ -57,9 +57,9 @@ type ExtBidderError struct {
 type ExtHttpCall struct {
 	Uri            string              `json:"uri"`
 	RequestBody    string              `json:"requestbody"`
+	RequestHeaders map[string][]string `json:"requestheaders"`
 	ResponseBody   string              `json:"responsebody"`
 	Status         int                 `json:"status"`
-	RequestHeaders map[string][]string `json:"requestheaders"`
 }
 
 // CookieStatus describes the allowed values for bidresponse.ext.usersync.{bidder}.status