Skip to content

Commit 8a3284d

Browse files
committed
fix review4: checkstyle
1 parent 992b6a4 commit 8a3284d

File tree

7 files changed

+10
-22
lines changed

7 files changed

+10
-22
lines changed

extra/modules/greenbids-real-time-data/src/main/java/org/prebid/server/hooks/modules/greenbids/real/time/data/config/GreenbidsRealTimeDataConfiguration.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import org.prebid.server.hooks.modules.greenbids.real.time.data.model.predictor.ThresholdCache;
1919
import org.prebid.server.hooks.modules.greenbids.real.time.data.v1.GreenbidsRealTimeDataModule;
2020
import org.prebid.server.hooks.modules.greenbids.real.time.data.v1.GreenbidsRealTimeDataProcessedAuctionRequestHook;
21-
import org.prebid.server.json.ObjectMapperProvider;
2221
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
2322
import org.springframework.boot.context.properties.EnableConfigurationProperties;
2423
import org.springframework.context.annotation.Bean;
@@ -40,7 +39,7 @@ public GreenbidsInferenceDataService greenbidsInferenceDataService(
4039
ObjectMapper mapper) {
4140

4241
final File database = new File(properties.getGeoLiteCountryPath());
43-
DatabaseReader dbReader;
42+
final DatabaseReader dbReader;
4443
try {
4544
dbReader = new DatabaseReader.Builder(database).build();
4645
} catch (IOException e) {

extra/modules/greenbids-real-time-data/src/main/java/org/prebid/server/hooks/modules/greenbids/real/time/data/model/data/GreenbidsInferenceDataService.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,12 @@
55
import com.fasterxml.jackson.databind.ObjectMapper;
66
import com.fasterxml.jackson.databind.node.ObjectNode;
77
import com.iab.openrtb.request.BidRequest;
8-
import com.iab.openrtb.request.Data;
98
import com.iab.openrtb.request.Device;
109
import com.iab.openrtb.request.Imp;
1110
import com.maxmind.geoip2.DatabaseReader;
1211
import com.maxmind.geoip2.exception.GeoIp2Exception;
1312
import com.maxmind.geoip2.model.CountryResponse;
1413
import com.maxmind.geoip2.record.Country;
15-
import io.netty.util.internal.StringUtil;
1614
import lombok.Value;
1715
import org.apache.commons.lang3.StringUtils;
1816
import org.prebid.server.exception.PreBidException;
@@ -28,7 +26,6 @@
2826
import java.util.List;
2927
import java.util.Optional;
3028
import java.util.stream.Collectors;
31-
import java.util.stream.Stream;
3229

3330
@Value(staticConstructor = "of")
3431
@Service

extra/modules/greenbids-real-time-data/src/main/java/org/prebid/server/hooks/modules/greenbids/real/time/data/model/predictor/FilterService.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111
import java.util.Map;
1212
import java.util.Objects;
1313
import java.util.stream.Collectors;
14-
import java.util.stream.IntStream;
15-
import java.util.stream.Stream;
1614
import java.util.stream.StreamSupport;
1715

1816
public class FilterService {
@@ -79,7 +77,7 @@ private Map<String, Map<String, Boolean>> processProbabilities(
7977
float[][] probabilities,
8078
List<ThrottlingMessage> throttlingMessages,
8179
Double threshold) {
82-
Map<String, Map<String, Boolean>> result = new HashMap<>();
80+
final Map<String, Map<String, Boolean>> result = new HashMap<>();
8381

8482
for (int i = 0; i < probabilities.length; i++) {
8583
final ThrottlingMessage message = throttlingMessages.get(i);

extra/modules/greenbids-real-time-data/src/main/java/org/prebid/server/hooks/modules/greenbids/real/time/data/model/predictor/ModelCache.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,9 @@ public Future<OnnxModelRunner> get(String onnxModelPath, String pbuid) {
6565

6666
private void fetchAndCacheModelRunner(String onnxModelPath, String cacheKey) {
6767
vertx.executeBlocking(promise -> {
68-
Blob blob = getBlob(onnxModelPath);
69-
promise.complete(blob);
70-
})
68+
final Blob blob = getBlob(onnxModelPath);
69+
promise.complete(blob);
70+
})
7171
.map(blob -> loadModelRunner((Blob) blob))
7272
.onSuccess(onnxModelRunner -> cache.put(cacheKey, onnxModelRunner))
7373
.onFailure(error -> logger.error("Failed to fetch ONNX model"));

extra/modules/greenbids-real-time-data/src/main/java/org/prebid/server/hooks/modules/greenbids/real/time/data/model/predictor/OnnxModelRunnerWithThresholds.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
11
package org.prebid.server.hooks.modules.greenbids.real.time.data.model.predictor;
22

3-
import com.fasterxml.jackson.databind.ObjectMapper;
4-
import com.github.benmanes.caffeine.cache.Cache;
5-
import com.google.cloud.storage.Storage;
63
import io.vertx.core.Future;
7-
import io.vertx.core.Vertx;
84
import org.prebid.server.hooks.modules.greenbids.real.time.data.core.Partner;
9-
import org.prebid.server.hooks.modules.greenbids.real.time.data.core.ThrottlingThresholds;
105

116
public class OnnxModelRunnerWithThresholds {
127

extra/modules/greenbids-real-time-data/src/main/java/org/prebid/server/hooks/modules/greenbids/real/time/data/model/predictor/ThresholdCache.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,12 +72,12 @@ public Future<ThrottlingThresholds> get(String thresholdJsonPath, String pbuid)
7272

7373
private void fetchAndCacheThrottlingThresholds(String thresholdJsonPath, String cacheKey) {
7474
vertx.executeBlocking(promise -> {
75-
Blob blob = getBlob(thresholdJsonPath);
76-
promise.complete(blob);
77-
})
75+
final Blob blob = getBlob(thresholdJsonPath);
76+
promise.complete(blob);
77+
})
7878
.map(blob -> loadThrottlingThresholds((Blob) blob))
7979
.onSuccess(thresholds -> cache.put(cacheKey, thresholds))
80-
.onFailure(error -> logger.error("Failed to fetch thresholds"));;
80+
.onFailure(error -> logger.error("Failed to fetch thresholds"));
8181
}
8282

8383
private Blob getBlob(String thresholdJsonPath) {

extra/modules/greenbids-real-time-data/src/main/java/org/prebid/server/hooks/modules/greenbids/real/time/data/v1/GreenbidsRealTimeDataProcessedAuctionRequestHook.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import com.fasterxml.jackson.databind.ObjectMapper;
66
import com.fasterxml.jackson.databind.node.ObjectNode;
77
import com.iab.openrtb.request.BidRequest;
8-
import com.maxmind.geoip2.DatabaseReader;
98
import io.vertx.core.Future;
109
import org.apache.commons.collections4.CollectionUtils;
1110
import org.prebid.server.auction.model.AuctionContext;
@@ -122,7 +121,7 @@ private Future<InvocationResult<AuctionRequestPayload>> toInvocationResult(
122121

123122
final Map<String, Map<String, Boolean>> impsBiddersFilterMap;
124123
try {
125-
List<ThrottlingMessage> throttlingMessages = greenbidsInferenceDataService
124+
final List<ThrottlingMessage> throttlingMessages = greenbidsInferenceDataService
126125
.extractThrottlingMessagesFromBidRequest(bidRequest);
127126

128127
impsBiddersFilterMap = filterService.filterBidders(

0 commit comments

Comments
 (0)