Skip to content

Commit 89cacc9

Browse files
RodionOretsRodionOrets
committed
IX: Set bidVideo when category and duration is available
1 parent e8e7bad commit 89cacc9

File tree

3 files changed

+77
-17
lines changed

3 files changed

+77
-17
lines changed

‎src/main/java/org/prebid/server/bidder/ix/IxBidder.java

Lines changed: 48 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
package org.prebid.server.bidder.ix;
22

3+
import com.fasterxml.jackson.core.JsonProcessingException;
34
import com.fasterxml.jackson.core.type.TypeReference;
5+
import com.fasterxml.jackson.databind.node.ObjectNode;
46
import com.iab.openrtb.request.Banner;
57
import com.iab.openrtb.request.BidRequest;
68
import com.iab.openrtb.request.Format;
@@ -24,6 +26,8 @@
2426
import org.prebid.server.proto.openrtb.ext.ExtPrebid;
2527
import org.prebid.server.proto.openrtb.ext.request.ix.ExtImpIx;
2628
import org.prebid.server.proto.openrtb.ext.response.BidType;
29+
import org.prebid.server.proto.openrtb.ext.response.ExtBidPrebid;
30+
import org.prebid.server.proto.openrtb.ext.response.ExtBidPrebidVideo;
2731
import org.prebid.server.util.HttpUtil;
2832

2933
import java.util.ArrayList;
@@ -194,21 +198,51 @@ public Result<List<BidderBid>> makeBids(HttpCall<BidRequest> httpCall, BidReques
194198
}
195199
}
196200

197-
private static List<BidderBid> extractBids(BidResponse bidResponse, BidRequest bidRequest) {
201+
private List<BidderBid> extractBids(BidResponse bidResponse, BidRequest bidRequest) {
198202
return bidResponse == null || CollectionUtils.isEmpty(bidResponse.getSeatbid())
199203
? Collections.emptyList()
200204
: bidsFromResponse(bidResponse, bidRequest);
201205
}
202206

203-
private static List<BidderBid> bidsFromResponse(BidResponse bidResponse, BidRequest bidRequest) {
207+
private List<BidderBid> bidsFromResponse(BidResponse bidResponse, BidRequest bidRequest) {
204208
return bidResponse.getSeatbid().stream()
205209
.map(SeatBid::getBid)
206210
.flatMap(Collection::stream)
207-
.map(bid -> prepareBid(bid, bidRequest))
208-
.map(bid -> BidderBid.of(bid, getBidType(bid.getImpid(), bidRequest.getImp()), bidResponse.getCur()))
211+
.map(bid -> toBidderBid(bid, bidRequest, bidResponse))
209212
.collect(Collectors.toList());
210213
}
211214

215+
private BidderBid toBidderBid(Bid bid, BidRequest bidRequest, BidResponse bidResponse) {
216+
final BidType bidType = getBidType(bid.getImpid(), bidRequest.getImp());
217+
218+
final ExtBidPrebid bidExt = parseBidExt(bid.getExt());
219+
final boolean bidHasNoSizes = bid.getH() == null || bid.getW() == null;
220+
final Banner banner = bidRequest.getImp().get(0).getBanner();
221+
if ((bidHasNoSizes && banner != null) || (bidExt != null && bidExt.getVideo() != null)) {
222+
final Bid.BidBuilder bidBuilder = bid.toBuilder();
223+
224+
if (bidHasNoSizes && banner != null) {
225+
bidBuilder
226+
.w(banner.getW())
227+
.h(banner.getH())
228+
.build();
229+
}
230+
231+
if (bidType == BidType.video) {
232+
if (bidExt != null && bidExt.getVideo() != null) {
233+
final ExtBidPrebidVideo video = bidExt.getVideo();
234+
bidBuilder.ext(toBidExt(video));
235+
if (CollectionUtils.isEmpty(bid.getCat())) {
236+
bidBuilder.cat(Collections.singletonList(video.getPrimaryCategory())).build();
237+
}
238+
}
239+
}
240+
bid = bidBuilder.build();
241+
}
242+
243+
return BidderBid.of(bid, bidType, bidResponse.getCur());
244+
}
245+
212246
private static BidType getBidType(String impId, List<Imp> imps) {
213247
for (Imp imp : imps) {
214248
if (imp.getId().equals(impId)) {
@@ -226,16 +260,16 @@ private static BidType getBidType(String impId, List<Imp> imps) {
226260
throw new PreBidException(String.format("Unmatched impression id %s", impId));
227261
}
228262

229-
private static Bid prepareBid(Bid bid, BidRequest bidRequest) {
230-
// Current implementation ensure that we have at least one imp in request
231-
final boolean bidHasNoSizes = bid.getH() == null || bid.getW() == null;
232-
final Banner banner = bidRequest.getImp().get(0).getBanner();
233-
if (bidHasNoSizes && banner != null) {
234-
return bid.toBuilder()
235-
.w(banner.getW())
236-
.h(banner.getH())
237-
.build();
263+
private ExtBidPrebid parseBidExt(ObjectNode bidExt) {
264+
try {
265+
return bidExt == null ? null : mapper.mapper().treeToValue(bidExt, ExtBidPrebid.class);
266+
} catch (JsonProcessingException e) {
267+
throw new PreBidException(e.getMessage());
238268
}
239-
return bid;
240269
}
270+
271+
private ObjectNode toBidExt(ExtBidPrebidVideo extBidVideo) {
272+
return mapper.mapper().valueToTree(ExtBidPrebidVideo.of(extBidVideo.getDuration(), null));
273+
}
274+
241275
}

‎src/main/resources/bidder-config/ix.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
adapters:
22
ix:
33
enabled: false
4-
endpoint: http://rubicon-us-east.lb.indexww.com/transbidder?p=189517
4+
endpoint: https://
55
pbs-enforces-gdpr: true
66
pbs-enforces-ccpa: true
77
modifying-vast-xml-allowed: true
@@ -22,8 +22,8 @@ adapters:
2222
supported-vendors:
2323
vendor-id: 10
2424
usersync:
25-
url:
26-
redirect-url:
25+
url: https://ssum.casalemedia.com/usermatchredir?s=189517&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&cb=
26+
redirect-url: /setuid?bidder=ix&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&uid=
2727
cookie-family-name: ix
2828
type: redirect
2929
support-cors: false

‎src/test/java/org/prebid/server/bidder/ix/IxBidderTest.java

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import org.prebid.server.proto.openrtb.ext.ExtPrebid;
2424
import org.prebid.server.proto.openrtb.ext.request.ix.ExtImpIx;
2525
import org.prebid.server.proto.openrtb.ext.response.BidType;
26+
import org.prebid.server.proto.openrtb.ext.response.ExtBidPrebidVideo;
2627

2728
import java.util.ArrayList;
2829
import java.util.List;
@@ -374,6 +375,31 @@ public void makeBidsShouldReturnBannerBidWithRequestImpSizeWhenBidSizeIsEmpty()
374375
.containsOnly(BidderBid.of(Bid.builder().impid("123").w(300).h(200).build(), BidType.banner, "EUR"));
375376
}
376377

378+
@Test
379+
public void makeBidsShouldReturnBidWithVideoExt() throws JsonProcessingException {
380+
// given
381+
final Video video = Video.builder().build();
382+
final HttpCall<BidRequest> httpCall = givenHttpCall(
383+
BidRequest.builder()
384+
.imp(singletonList(Imp.builder().id("123").video(video).build()))
385+
.build(),
386+
mapper.writeValueAsString(
387+
givenBidResponse(
388+
bidBuilder -> bidBuilder
389+
.impid("123")
390+
.ext(mapper.valueToTree(ExtPrebid.of(null, ExtBidPrebidVideo.of(1, "cat")))))));
391+
392+
// when
393+
final Result<List<BidderBid>> result = ixBidder.makeBids(httpCall, null);
394+
395+
// then
396+
assertThat(result.getErrors()).isEmpty();
397+
assertThat(result.getValue())
398+
.extracting(BidderBid::getBid)
399+
.extracting(Bid::getExt)
400+
.containsExactly(mapper.valueToTree(ExtPrebid.of(null, ExtBidPrebidVideo.of(1, "cat"))));
401+
}
402+
377403
private static BidRequest givenBidRequest(
378404
Function<BidRequest.BidRequestBuilder, BidRequest.BidRequestBuilder> bidRequestCustomizer,
379405
Function<Imp.ImpBuilder, Imp.ImpBuilder> impCustomizer) {

0 commit comments

Comments
 (0)