Skip to content

Commit 819aa87

Browse files
RodionOretsRodionOrets
committed
IX: Set bidVideo when category and duration is available
1 parent cb62ab3 commit 819aa87

File tree

3 files changed

+79
-17
lines changed

3 files changed

+79
-17
lines changed

‎src/main/java/org/prebid/server/bidder/ix/IxBidder.java

Lines changed: 45 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
package org.prebid.server.bidder.ix;
22

3+
import com.fasterxml.jackson.core.JsonProcessingException;
34
import com.fasterxml.jackson.core.type.TypeReference;
5+
import com.fasterxml.jackson.databind.node.ObjectNode;
46
import com.iab.openrtb.request.Banner;
57
import com.iab.openrtb.request.BidRequest;
68
import com.iab.openrtb.request.Format;
@@ -24,6 +26,8 @@
2426
import org.prebid.server.proto.openrtb.ext.ExtPrebid;
2527
import org.prebid.server.proto.openrtb.ext.request.ix.ExtImpIx;
2628
import org.prebid.server.proto.openrtb.ext.response.BidType;
29+
import org.prebid.server.proto.openrtb.ext.response.ExtBidPrebid;
30+
import org.prebid.server.proto.openrtb.ext.response.ExtBidPrebidVideo;
2731
import org.prebid.server.util.HttpUtil;
2832

2933
import java.util.ArrayList;
@@ -46,6 +50,8 @@ public class IxBidder implements Bidder<BidRequest> {
4650
// maximum number of bid requests
4751
private static final int REQUEST_LIMIT = 20;
4852

53+
private static final String PREBID = "prebid";
54+
4955
private final String endpointUrl;
5056
private final JacksonMapper mapper;
5157

@@ -194,21 +200,46 @@ public Result<List<BidderBid>> makeBids(HttpCall<BidRequest> httpCall, BidReques
194200
}
195201
}
196202

197-
private static List<BidderBid> extractBids(BidResponse bidResponse, BidRequest bidRequest) {
203+
private List<BidderBid> extractBids(BidResponse bidResponse, BidRequest bidRequest) {
198204
return bidResponse == null || CollectionUtils.isEmpty(bidResponse.getSeatbid())
199205
? Collections.emptyList()
200206
: bidsFromResponse(bidResponse, bidRequest);
201207
}
202208

203-
private static List<BidderBid> bidsFromResponse(BidResponse bidResponse, BidRequest bidRequest) {
209+
private List<BidderBid> bidsFromResponse(BidResponse bidResponse, BidRequest bidRequest) {
204210
return bidResponse.getSeatbid().stream()
205211
.map(SeatBid::getBid)
206212
.flatMap(Collection::stream)
207-
.map(bid -> prepareBid(bid, bidRequest))
208-
.map(bid -> BidderBid.of(bid, getBidType(bid.getImpid(), bidRequest.getImp()), bidResponse.getCur()))
213+
.map(bid -> toBidderBid(bid, bidRequest, bidResponse))
209214
.collect(Collectors.toList());
210215
}
211216

217+
private BidderBid toBidderBid(Bid bid, BidRequest bidRequest, BidResponse bidResponse) {
218+
final BidType bidType = getBidType(bid.getImpid(), bidRequest.getImp());
219+
220+
Bid.BidBuilder bidBuilder = bid.toBuilder();
221+
222+
final boolean bidHasNoSizes = bid.getH() == null || bid.getW() == null;
223+
final Banner banner = bidRequest.getImp().get(0).getBanner();
224+
if (bidHasNoSizes && banner != null) {
225+
bidBuilder
226+
.w(banner.getW())
227+
.h(banner.getH())
228+
.build();
229+
}
230+
231+
final ExtBidPrebid bidExt = parseBidExt(bid.getExt());
232+
if (bidExt != null && bidExt.getVideo() != null) {
233+
final ExtBidPrebidVideo video = bidExt.getVideo();
234+
bidBuilder.ext(toBidExt(video));
235+
if (bid.getCat().size() == 0) {
236+
bidBuilder.cat(Collections.singletonList(video.getPrimaryCategory())).build();
237+
}
238+
}
239+
240+
return BidderBid.of(bidBuilder.build(), bidType, bidResponse.getCur());
241+
}
242+
212243
private static BidType getBidType(String impId, List<Imp> imps) {
213244
for (Imp imp : imps) {
214245
if (imp.getId().equals(impId)) {
@@ -226,16 +257,16 @@ private static BidType getBidType(String impId, List<Imp> imps) {
226257
throw new PreBidException(String.format("Unmatched impression id %s", impId));
227258
}
228259

229-
private static Bid prepareBid(Bid bid, BidRequest bidRequest) {
230-
// Current implementation ensure that we have at least one imp in request
231-
final boolean bidHasNoSizes = bid.getH() == null || bid.getW() == null;
232-
final Banner banner = bidRequest.getImp().get(0).getBanner();
233-
if (bidHasNoSizes && banner != null) {
234-
return bid.toBuilder()
235-
.w(banner.getW())
236-
.h(banner.getH())
237-
.build();
260+
private ExtBidPrebid parseBidExt(ObjectNode bidExt) {
261+
try {
262+
return bidExt == null ? null : mapper.mapper().treeToValue(bidExt, ExtBidPrebid.class);
263+
} catch (JsonProcessingException e) {
264+
throw new PreBidException(e.getMessage());
238265
}
239-
return bid;
240266
}
267+
268+
private ObjectNode toBidExt(ExtBidPrebidVideo extBidVideo) {
269+
return mapper.mapper().valueToTree(ExtBidPrebidVideo.of(extBidVideo.getDuration(), null));
270+
}
271+
241272
}

‎src/main/resources/bidder-config/ix.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
adapters:
22
ix:
33
enabled: false
4-
endpoint: http://rubicon-us-east.lb.indexww.com/transbidder?p=189517
4+
endpoint: https://
55
pbs-enforces-gdpr: true
66
pbs-enforces-ccpa: true
77
modifying-vast-xml-allowed: true
@@ -22,8 +22,8 @@ adapters:
2222
supported-vendors:
2323
vendor-id: 10
2424
usersync:
25-
url:
26-
redirect-url:
25+
url: https://ssum.casalemedia.com/usermatchredir?gdpr={{gdpr}}&gdpr_consent={{gdpr_consent}}&us_privacy={{us_privacy}}&r=
26+
redirect-url: /setuid?bidder=ix&gdpr={{gdpr}}&gdpr_consent={{gdpr_consent}}&us_privacy={{us_privacy}}&uid={{uid}}
2727
cookie-family-name: ix
2828
type: redirect
2929
support-cors: false

‎src/test/java/org/prebid/server/bidder/ix/IxBidderTest.java

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import org.prebid.server.proto.openrtb.ext.ExtPrebid;
2424
import org.prebid.server.proto.openrtb.ext.request.ix.ExtImpIx;
2525
import org.prebid.server.proto.openrtb.ext.response.BidType;
26+
import org.prebid.server.proto.openrtb.ext.response.ExtBidPrebidVideo;
2627

2728
import java.util.ArrayList;
2829
import java.util.List;
@@ -374,6 +375,36 @@ public void makeBidsShouldReturnBannerBidWithRequestImpSizeWhenBidSizeIsEmpty()
374375
.containsOnly(BidderBid.of(Bid.builder().impid("123").w(300).h(200).build(), BidType.banner, "EUR"));
375376
}
376377

378+
@Test
379+
public void makeBidsShouldReturnBidWithVideoExt() throws JsonProcessingException {
380+
// given
381+
final Video video = Video.builder().build();
382+
final HttpCall<BidRequest> httpCall = givenHttpCall(
383+
BidRequest.builder()
384+
.imp(singletonList(Imp.builder().id("123").video(video).build()))
385+
.build(),
386+
mapper.writeValueAsString(
387+
givenBidResponse(
388+
bidBuilder -> bidBuilder
389+
.impid("123")
390+
.w(300).h(200)
391+
.ext(mapper.valueToTree(ExtPrebid.of(null, ExtBidPrebidVideo.of(1, "cat")))))));
392+
393+
// when
394+
final Result<List<BidderBid>> result = ixBidder.makeBids(httpCall, null);
395+
396+
// then
397+
assertThat(result.getErrors()).isEmpty();
398+
assertThat(result.getValue())
399+
.containsOnly(
400+
BidderBid.of(Bid.builder()
401+
.impid("123")
402+
.w(300)
403+
.h(200)
404+
.ext(mapper.valueToTree(ExtPrebid.of(null, ExtBidPrebidVideo.of(1, "cat"))))
405+
.build(), BidType.video, "EUR"));
406+
}
407+
377408
private static BidRequest givenBidRequest(
378409
Function<BidRequest.BidRequestBuilder, BidRequest.BidRequestBuilder> bidRequestCustomizer,
379410
Function<Imp.ImpBuilder, Imp.ImpBuilder> impCustomizer) {

0 commit comments

Comments
 (0)