Skip to content

Commit 1240151

Browse files
committed
fix review6: mapper dbReader field access
1 parent 7d35997 commit 1240151

File tree

1 file changed

+8
-16
lines changed

1 file changed

+8
-16
lines changed

extra/modules/greenbids-real-time-data/src/main/java/org/prebid/server/hooks/modules/greenbids/real/time/data/model/data/GreenbidsInferenceDataService.java

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -46,16 +46,12 @@ public List<ThrottlingMessage> extractThrottlingMessagesFromBidRequest(BidReques
4646

4747
return extractThrottlingMessages(
4848
bidRequest,
49-
userAgent,
50-
dbReader,
51-
mapper);
49+
userAgent);
5250
}
5351

5452
private List<ThrottlingMessage> extractThrottlingMessages(
5553
BidRequest bidRequest,
56-
GreenbidsUserAgent greenbidsUserAgent,
57-
DatabaseReader dbReader,
58-
ObjectMapper mapper) {
54+
GreenbidsUserAgent greenbidsUserAgent) {
5955

6056
final ZonedDateTime timestamp = ZonedDateTime.now(ZoneId.of("UTC"));
6157
final Integer hourBucket = timestamp.getHour();
@@ -71,9 +67,7 @@ private List<ThrottlingMessage> extractThrottlingMessages(
7167
greenbidsUserAgent,
7268
hostname,
7369
hourBucket,
74-
minuteQuadrant,
75-
dbReader,
76-
mapper))
70+
minuteQuadrant))
7771
.flatMap(Collection::stream)
7872
.collect(Collectors.toList());
7973
}
@@ -84,17 +78,15 @@ private List<ThrottlingMessage> extractMessagesForImp(
8478
GreenbidsUserAgent greenbidsUserAgent,
8579
String hostname,
8680
Integer hourBucket,
87-
Integer minuteQuadrant,
88-
DatabaseReader dbReader,
89-
ObjectMapper mapper) {
81+
Integer minuteQuadrant) {
9082

9183
final String impId = imp.getId();
9284
final ObjectNode impExt = imp.getExt();
93-
final JsonNode bidderNode = extImpPrebid(impExt.get("prebid"), mapper).getBidder();
85+
final JsonNode bidderNode = extImpPrebid(impExt.get("prebid")).getBidder();
9486
final String ip = Optional.ofNullable(bidRequest.getDevice())
9587
.map(Device::getIp)
9688
.orElse(null);
97-
final String countryFromIp = getCountry(ip, dbReader);
89+
final String countryFromIp = getCountry(ip);
9890
return createThrottlingMessages(
9991
bidderNode,
10092
impId,
@@ -105,7 +97,7 @@ private List<ThrottlingMessage> extractMessagesForImp(
10597
minuteQuadrant);
10698
}
10799

108-
private String getCountry(String ip, DatabaseReader dbReader) {
100+
private String getCountry(String ip) {
109101
if (ip == null) {
110102
return null;
111103
}
@@ -181,7 +173,7 @@ private ThrottlingMessage buildThrottlingMessage(
181173
.build();
182174
}
183175

184-
private ExtImpPrebid extImpPrebid(JsonNode extImpPrebid, ObjectMapper mapper) {
176+
private ExtImpPrebid extImpPrebid(JsonNode extImpPrebid) {
185177
try {
186178
return mapper.treeToValue(extImpPrebid, ExtImpPrebid.class);
187179
} catch (JsonProcessingException e) {

0 commit comments

Comments
 (0)