Skip to content

Yieldbot impression image creation fix #2277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2018

Conversation

elljoh
Copy link
Contributor

@elljoh elljoh commented Mar 16, 2018

Type of change

  • Bugfix

Description of change

Creative markup minified string was malformed for impression pixel Image creation. Specifically, the space between the new operator and the image element constructor function was missing. :/

The change writes from:

  • newImage
    TO;
  • new Image

Other Information

  • Reviewing process that introduced the issue; and
  • Re-thinking integration test procedures regarding DOM element initiated requests...

@bretg bretg added LGTM and removed in progress labels Mar 19, 2018
@bretg bretg merged commit 3e7df0d into prebid:master Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants