Skip to content

GPP module: update to support 1.1 including callback compatability, ready status, deprecation getGPPDATA #9483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
patmmccann opened this issue Jan 30, 2023 · 3 comments · Fixed by #10282

Comments

@patmmccann
Copy link
Collaborator

patmmccann commented Jan 30, 2023

Type of issue

Mirroring InteractiveAdvertisingBureau/Global-Privacy-Platform#51 it appears at

invokeCMP({command: 'getGPPData'}, function (gppData) {
we call the cmp after hearing a change event. Could we instead rely on the data in the callback to have the section change data?

https://github.com/InteractiveAdvertisingBureau/Global-Privacy-Platform/blob/606b99efc16b649c5c1f8f1d2eb0d0d3258c4a2d/Core/CMP%20API%20Specification.md?plain=1#L273

Since we invoke the cmp getgppdata command after the event, does our solution work in a frame or if the cmp is in a frame as TCF does?

How should we give feedback to the IABTL on our preference for the outcome of their issue 51? Assuming they go with solution 1, I assume we need to change our invoke cmp call to expect different behavior.

@brondsem
Copy link
Contributor

brondsem commented Feb 1, 2023

Looks like there are API changes coming to support this: InteractiveAdvertisingBureau/Global-Privacy-Platform#55

The changes would also remove getGPPData and instead the ping command would return the full GPP string. So consentManagementGpp.js will need changes

@patmmccann
Copy link
Collaborator Author

patmmccann commented Feb 2, 2023

In the IABTL meeting now, instead of double calling the cmp, the event listener return should have the data and we dont need to call ping, gppdata, nor getsection

also the gpp version should increment on pr 55 over there; i think we can just not support the old gpp version going forward instead of needing to support the pre-55 gpp.

@patmmccann patmmccann moved this from Triage to Ready for Dev in Prebid.js Tactical Issues table Feb 2, 2023
@patmmccann patmmccann changed the title GPP module iframe compatability GPP module callback compatability Feb 2, 2023
@dgirardi
Copy link
Collaborator

This does not appear ready for development. The only GPP aware CMP that I know (from this test) does not provide GPP consent data from the event payload, the call to getGPPData is required as far as I can tell.

@dgirardi dgirardi moved this from Ready for Dev to Needs Req in Prebid.js Tactical Issues table Mar 13, 2023
@patmmccann patmmccann changed the title GPP module callback compatability GPP module: update to support 1.1 including callback compatability, ready status, deprecation getGPPDATA Mar 27, 2023
@patmmccann patmmccann moved this from Needs Req to Blocked in Prebid.js Tactical Issues table Mar 27, 2023
@patmmccann patmmccann moved this from Blocked to Ready for Dev in Prebid.js Tactical Issues table Jul 19, 2023
@patmmccann patmmccann moved this from Ready for Dev to PR submitted in Prebid.js Tactical Issues table Jul 27, 2023
@github-project-automation github-project-automation bot moved this from PR submitted to Done in Prebid.js Tactical Issues table Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants