Skip to content

Intent to Implement: Allow selection of supported default targeting keys at configuration time. #5670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mimenet opened this issue Aug 27, 2020 · 2 comments

Comments

@mimenet
Copy link
Collaborator

mimenet commented Aug 27, 2020

Type of issue

Intent to implement

Description

Prebid default targeting includes keys that are not be needed by all publishers. The inclusion of these keys and their corresponding values can lead to /gampad/ads requests being truncated. Publishers in this situation would benefit from an option that allows them to select which default keys they would like to employ.
The proposal is to allow publishers to select the default keys they would like to support, without changing how those keys are generated or otherwise managed.

Requirements

  1. Default targeting keys can be suppressed, custom targeting keys cannot.
  2. AdserverTargeting objects are not changed.
  3. Targeting return by targeting.getAllTargeting is affected without side effects.
  4. Keys are identified by their key name in constants.json.
  5. Targeting is removed when a key contains a full substring match of a non-supported default key at position 0.
  6. This should be settable with pbjs.setConfig.

Proposed External Interface

Supporting only hb_bidder, hb_adid, and hb_pb would look like this:

pbjs.setConfig({
  "targetingControls": {
    "allowTargetingKeys": ["BIDDER", "AD_ID", "PRICE_BUCKET"]
  }
});

Other information

This proposal is based on conversations in prebid.js PMC
Prebid.js PR found here: #5763

@stale
Copy link

stale bot commented Sep 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 4, 2020
@stale stale bot closed this as completed Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant