Skip to content

hb_cache_id is not set on DFP video request in Prebid 2.7 #3664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nanek opened this issue Mar 21, 2019 · 2 comments · Fixed by #3668
Closed

hb_cache_id is not set on DFP video request in Prebid 2.7 #3664

nanek opened this issue Mar 21, 2019 · 2 comments · Fixed by #3668

Comments

@nanek
Copy link
Contributor

nanek commented Mar 21, 2019

Type of issue

bug

Description

hb_cache_id is not set as parameter on DFP video request in Prebid 2.7. Works in Prebid 2.3. I can see that videoCacheKey is set properly on bidResponse.

I think it might be related to https://github.com/prebid/Prebid.js/pull/3605/files#diff-f9e9cab460a9c83c3110b246bd4326e2L165

This results in making a request to https://prebid.adnxs.com/pbc/v1/cache?uuid= which is invalid as it is missing the uuid. This then causes a VAST 301 error.

Steps to reproduce

I'm pretty sure it is happening for multiple partners, but I'm testing with oneVideo right now and can confirm it there.

 var adTagUrl = pbjs.adServers.dfp.buildVideoUrl({
      adUnit: videoAdUnit,
      params: params,
      bid: bidWithHighestCpm})

Test page

Expected results

Actual results

Platform details

Prebid 2.7

Other information

@jaiminpanchal27
Copy link
Collaborator

@nanek Thanks for reporting this. We are working on this and will be fixed in next release. We will be adding both the keys back in dfp module.

Summary of what happened

hb_uuid and hb_cache_id are both standard keys for video. In 2.4 and before, if publisher overwrites the standard keys using pbjs.bidderSettings then both these were getting set to undefined due to the order in which some core operations were getting executed.

Hence we were adding both hb_uuid and hb_cache_id with the targeting data from dfp module.
Now in 2.5 we fixed bug explained above. So if you are to overwrite standard keys, you should also add

{
  key: 'hb_cache_id',
  val: function (bidResponse) {
    return bidResponse.videoCacheKey;
  }
}, {
  key: 'hb_uuid',
  val: function (bidResponse) {
    return bidResponse.videoCacheKey;
  }
}

@nanek
Copy link
Contributor Author

nanek commented Mar 21, 2019

I do overwrite the standard keys, and I don't set the hb_cache_id key. I'll do that, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants