Skip to content

Commit f849022

Browse files
committed
convert adapters: adagio
1 parent e861922 commit f849022

File tree

2 files changed

+17
-22
lines changed

2 files changed

+17
-22
lines changed

modules/adagioBidAdapter.js

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,13 @@ import {
1919
logInfo,
2020
logWarn,
2121
mergeDeep,
22-
parseUrl
2322
} from '../src/utils.js';
2423
import {config} from '../src/config.js';
2524
import {registerBidder} from '../src/adapters/bidderFactory.js';
2625
import {loadExternalScript} from '../src/adloader.js';
2726
import {verify} from 'criteo-direct-rsa-validate/build/verify.js';
2827
import {getStorageManager} from '../src/storageManager.js';
29-
import {getRefererInfo} from '../src/refererDetection.js';
28+
import {getRefererInfo, parseDomain} from '../src/refererDetection.js';
3029
import {createEidsArray} from './userId/eids.js';
3130
import {BANNER, NATIVE, VIDEO} from '../src/mediaTypes.js';
3231
import {Renderer} from '../src/Renderer.js';
@@ -270,12 +269,11 @@ function getDevice() {
270269

271270
function getSite(bidderRequest) {
272271
const { refererInfo } = bidderRequest;
273-
const url = parseUrl(refererInfo.referer);
274-
275272
return {
276-
domain: url.hostname || '',
277-
page: refererInfo.referer || '',
278-
referrer: canAccessTopWindow() ? getWindowTop().document.referrer || '' : getWindowSelf().document.referrer || '',
273+
// TODO: do these fallbacks make sense?
274+
domain: refererInfo.domain || parseDomain(refererInfo.topmostLocation) || '',
275+
page: refererInfo.page || refererInfo.topmostLocation || '',
276+
referrer: refererInfo.ref || getWindowSelf().document.referrer || '',
279277
top: refererInfo.reachedTop
280278
};
281279
};

test/spec/modules/adagioBidAdapter_spec.js

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1381,21 +1381,13 @@ describe('Adagio bid adapter', () => {
13811381

13821382
describe('site information using refererDetection or window.top', function() {
13831383
it('should returns domain, page and window.referrer in a window.top context', function() {
1384-
sandbox.stub(utils, 'getWindowTop').returns({
1385-
location: {
1386-
hostname: 'test.io',
1387-
href: 'https://test.io/article/a.html'
1388-
},
1389-
document: {
1390-
referrer: 'https://google.com'
1391-
}
1392-
});
1393-
13941384
const bidderRequest = new BidderRequestBuilder({
13951385
refererInfo: {
13961386
numIframes: 0,
13971387
reachedTop: true,
1398-
referer: 'https://test.io/article/a.html'
1388+
page: 'https://test.io/article/a.html',
1389+
domain: 'test.io',
1390+
ref: 'https://google.com'
13991391
}
14001392
}).build();
14011393

@@ -1418,13 +1410,15 @@ describe('Adagio bid adapter', () => {
14181410
const info = {
14191411
numIframes: 0,
14201412
reachedTop: true,
1421-
referer: 'http://level.io/',
1413+
page: 'http://level.io/',
14221414
stack: [
14231415
'http://level.io/',
14241416
'http://example.com/iframe1.html',
14251417
'http://example.com/iframe2.html'
14261418
],
1427-
canonicalUrl: ''
1419+
canonicalUrl: '',
1420+
domain: 'level.io',
1421+
ref: null,
14281422
};
14291423

14301424
const bidderRequest = new BidderRequestBuilder({
@@ -1445,13 +1439,16 @@ describe('Adagio bid adapter', () => {
14451439
const info = {
14461440
numIframes: 2,
14471441
reachedTop: false,
1448-
referer: 'http://example.com/iframe1.html',
1442+
topmostLocation: 'http://example.com/iframe1.html',
14491443
stack: [
14501444
null,
14511445
'http://example.com/iframe1.html',
14521446
'http://example.com/iframe2.html'
14531447
],
1454-
canonicalUrl: ''
1448+
canonicalUrl: '',
1449+
page: null,
1450+
domain: null,
1451+
ref: null
14551452
};
14561453

14571454
const bidderRequest = new BidderRequestBuilder({

0 commit comments

Comments
 (0)