Skip to content

Commit dd4b25e

Browse files
authored
Adf Bid Adapter getFloor update (#10211)
* adfBidAdapter getFloor update * syntax fix * Better manner for tests
1 parent 7a2a6e8 commit dd4b25e

File tree

2 files changed

+51
-1
lines changed

2 files changed

+51
-1
lines changed

modules/adfBidAdapter.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,11 @@ export const spec = {
6969
bid.netRevenue = pt;
7070

7171
const floorInfo = bid.getFloor ? bid.getFloor({
72-
currency: currency || 'USD'
72+
currency: currency || 'USD',
73+
size: '*',
74+
mediaType: '*'
7375
}) : {};
76+
7477
const bidfloor = floorInfo.floor;
7578
const bidfloorcur = floorInfo.currency;
7679
const { mid, inv, mname } = bid.params;

test/spec/modules/adfBidAdapter_spec.js

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
// jshint esversion: 6, es3: false, node: true
2+
/* eslint-disable no-console */
23
import { assert } from 'chai';
34
import { spec } from 'modules/adfBidAdapter.js';
45
import { config } from 'src/config.js';
@@ -446,6 +447,52 @@ describe('Adf adapter', function () {
446447
});
447448
});
448449

450+
it('should add correct params to getFloor', function () {
451+
let result;
452+
let mediaTypes = { video: {
453+
playerSize: [ 100, 200 ]
454+
} };
455+
const expectedFloors = [ 1, 1.3, 0.5 ];
456+
config.setConfig({ currency: { adServerCurrency: 'DKK' } });
457+
let validBidRequests = expectedFloors.map(getBidWithFloorTest);
458+
getRequestImps(validBidRequests);
459+
assert.deepEqual(result, { currency: 'DKK', size: '*', mediaType: '*' });
460+
461+
mediaTypes = { banner: {
462+
sizes: [ [100, 200], [300, 400] ]
463+
}};
464+
validBidRequests = expectedFloors.map(getBidWithFloorTest);
465+
getRequestImps(validBidRequests);
466+
467+
assert.deepEqual(result, { currency: 'DKK', size: '*', mediaType: '*' });
468+
469+
mediaTypes = { native: {} };
470+
validBidRequests = expectedFloors.map(getBidWithFloorTest);
471+
getRequestImps(validBidRequests);
472+
473+
assert.deepEqual(result, { currency: 'DKK', size: '*', mediaType: '*' });
474+
475+
mediaTypes = {};
476+
validBidRequests = expectedFloors.map(getBidWithFloorTest);
477+
getRequestImps(validBidRequests);
478+
479+
assert.deepEqual(result, { currency: 'DKK', size: '*', mediaType: '*' });
480+
481+
function getBidWithFloorTest(floor) {
482+
return {
483+
params: { mid: 1 },
484+
mediaTypes: mediaTypes,
485+
getFloor: (args) => {
486+
result = args;
487+
return {
488+
currency: 'DKK',
489+
floor
490+
};
491+
}
492+
};
493+
}
494+
});
495+
449496
function getBidWithFloor(floor) {
450497
return {
451498
params: { mid: 1 },

0 commit comments

Comments
 (0)