VIS.X: fix bug with onTimeout function arguments (#8110)

Co-authored-by: Vladimir Fedoseev <[email protected]>

Author: vfedoseev

modules/visxBidAdapter.js

@@ -42,7 +42,7 @@ export const spec = {
         }
       }
     }
-    return !!bid.params.uid;
+    return !!bid.params.uid && !isNaN(parseInt(bid.params.uid));
   },
   buildRequests: function(validBidRequests, bidderRequest) {
     const auids = [];
@@ -203,6 +203,15 @@ export const spec = {
   },
   onTimeout: function(timeoutData) {
     // Call '/track/bid_timeout' with timeout data
+    timeoutData.forEach(({ params }) => {
+      if (params) {
+        params.forEach((item) => {
+          if (item && item.uid) {
+            item.uid = parseInt(item.uid);
+          }
+        });
+      }
+    });
     triggerPixel(buildUrl(TRACK_TIMEOUT_PATH) + '//' + JSON.stringify(timeoutData));
   }
 };
@@ -249,7 +258,7 @@ function buildImpObject(bid) {
     ...(banner && { banner }),
     ...(video && { video }),
     ext: {
-      bidder: { uid: Number(uid) },
+      bidder: { uid: parseInt(uid) },
     }
   };
 

test/spec/modules/visxBidAdapter_spec.js

@@ -18,7 +18,7 @@ describe('VisxAdapter', function () {
     let bid = {
       'bidder': 'visx',
       'params': {
-        'uid': '903536'
+        'uid': 903536
       },
       'adUnitCode': 'adunit-code',
       'sizes': [[300, 250], [300, 600]],
@@ -40,6 +40,15 @@ describe('VisxAdapter', function () {
       expect(spec.isBidRequestValid(bid)).to.equal(false);
     });
 
+    it('should return false when uid can not be parsed as number', function () {
+      let bid = Object.assign({}, bid);
+      delete bid.params;
+      bid.params = {
+        'uid': 'sdvsdv'
+      };
+      expect(spec.isBidRequestValid(bid)).to.equal(false);
+    });
+
     it('it should fail on invalid video bid', function () {
       let videoBid = Object.assign({}, bid);
       videoBid.mediaTypes = {
@@ -102,7 +111,7 @@ describe('VisxAdapter', function () {
       {
         'bidder': 'visx',
         'params': {
-          'uid': 903535
+          'uid': '903535'
         },
         'adUnitCode': 'adunit-code-2',
         'sizes': [[728, 90], [300, 250]],
@@ -1263,9 +1272,10 @@ describe('VisxAdapter', function () {
     });
 
     it('onTimeout', function () {
-      const data = { timeout: 3000, bidId: '23423', params: { uid: 1 } };
+      const data = [{ timeout: 3000, adUnitCode: 'adunit-code-1', auctionId: '1cbd2feafe5e8b', bidder: 'visx', bidId: '23423', params: [{ uid: '1' }] }];
+      const expectedData = [{ ...data[0], params: [{ uid: 1 }] }];
       spec.onTimeout(data);
-      expect(utils.triggerPixel.calledOnceWith('https://t.visx.net/track/bid_timeout//' + JSON.stringify(data))).to.equal(true);
+      expect(utils.triggerPixel.calledOnceWith('https://t.visx.net/track/bid_timeout//' + JSON.stringify(expectedData))).to.equal(true);
     });
   });