Skip to content

Commit ab4e778

Browse files
committed
convert bidders: loglyft
1 parent f6c3be0 commit ab4e778

File tree

5 files changed

+12
-11
lines changed

5 files changed

+12
-11
lines changed

modules/lkqdBidAdapter.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@ export const spec = {
3737
const UTC_OFFSET = new Date().getTimezoneOffset();
3838
const UA = navigator.userAgent;
3939
const USP = BIDDER_REQUEST.uspConsent || null;
40-
const REFERER = BIDDER_REQUEST.refererInfo ? new URL(BIDDER_REQUEST.refererInfo.referer).hostname : window.location.hostname;
40+
// TODO: does the fallback make sense here?
41+
const REFERER = BIDDER_REQUEST?.refererInfo?.domain || window.location.hostname
4142
const BIDDER_GDPR = BIDDER_REQUEST.gdprConsent && BIDDER_REQUEST.gdprConsent.gdprApplies ? 1 : null;
4243
const BIDDER_GDPRS = BIDDER_REQUEST.gdprConsent && BIDDER_REQUEST.gdprConsent.consentString ? BIDDER_REQUEST.gdprConsent.consentString : null;
4344

modules/lockerdomeBidAdapter.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,11 @@ export const spec = {
2121
};
2222
});
2323

24-
const bidderRequestCanonicalUrl = (bidderRequest && bidderRequest.refererInfo && bidderRequest.refererInfo.canonicalUrl) || '';
25-
const bidderRequestReferer = (bidderRequest && bidderRequest.refererInfo && bidderRequest.refererInfo.referer) || '';
2624
const payload = {
2725
bidRequests: adUnitBidRequests,
28-
url: encodeURIComponent(bidderRequestCanonicalUrl),
29-
referrer: encodeURIComponent(bidderRequestReferer)
26+
// TODO: are these the right refererInfo values?
27+
url: encodeURIComponent(bidderRequest?.refererInfo?.canonicalUrl || ''),
28+
referrer: encodeURIComponent(bidderRequest?.refererInfo?.topmostLocation || '')
3029
};
3130
if (schain) {
3231
payload.schain = schain;

modules/loglyliftBidAdapter.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,8 @@ function newBidRequest(bid, bidderRequest) {
6969
params: bid.params,
7070
prebidJsVersion: '$prebid.version$',
7171
url: window.location.href,
72-
domain: config.getConfig('publisherDomain'),
73-
referer: bidderRequest.refererInfo.referer,
72+
domain: bidderRequest.refererInfo.domain,
73+
referer: bidderRequest.refererInfo.page,
7474
auctionStartTime: bidderRequest.auctionStart,
7575
currency: currency,
7676
timeout: config.getConfig('bidderTimeout')

test/spec/modules/lockerdomeBidAdapter_spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ describe('LockerDomeAdapter', function () {
7474
const bidderRequest = {
7575
refererInfo: {
7676
canonicalUrl: 'https://example.com/canonical',
77-
referer: 'https://example.com'
77+
topmostLocation: 'https://example.com'
7878
}
7979
};
8080
const request = spec.buildRequests(bidRequests, bidderRequest);
@@ -88,7 +88,7 @@ describe('LockerDomeAdapter', function () {
8888
expect(bids).to.have.lengthOf(2);
8989

9090
expect(requestData.url).to.equal(encodeURIComponent(bidderRequest.refererInfo.canonicalUrl));
91-
expect(requestData.referrer).to.equal(encodeURIComponent(bidderRequest.refererInfo.referer));
91+
expect(requestData.referrer).to.equal(encodeURIComponent(bidderRequest.refererInfo.topmostLocation));
9292

9393
expect(bids[0].requestId).to.equal('2652ca954bce9');
9494
expect(bids[0].adUnitCode).to.equal('ad-1');

test/spec/modules/loglyliftBidAdapter_spec.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,8 @@ describe('loglyliftBidAdapter', function () {
5757

5858
const bidderRequest = {
5959
refererInfo: {
60-
referer: 'fakeReferer',
60+
domain: 'domain',
61+
page: 'fakeReferer',
6162
reachedTop: true,
6263
numIframes: 1,
6364
stack: []
@@ -152,7 +153,7 @@ describe('loglyliftBidAdapter', function () {
152153
expect(data.prebidJsVersion).to.equal('$prebid.version$');
153154
expect(data.url).to.exist;
154155
expect(data.domain).to.exist;
155-
expect(data.referer).to.equal(bidderRequest.refererInfo.referer);
156+
expect(data.referer).to.equal(bidderRequest.refererInfo.page);
156157
expect(data.auctionStartTime).to.equal(bidderRequest.auctionStart);
157158
expect(data.currency).to.exist;
158159
expect(data.timeout).to.equal(bidderRequest.timeout);

0 commit comments

Comments
 (0)