Skip to content

Commit 985dcbc

Browse files
committed
convert bidders: criteo
1 parent 5cf6955 commit 985dcbc

File tree

6 files changed

+14
-9
lines changed

6 files changed

+14
-9
lines changed

modules/cpmstarBidAdapter.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ export const spec = {
4646

4747
for (var i = 0; i < validBidRequests.length; i++) {
4848
var bidRequest = validBidRequests[i];
49-
var referer = encodeURIComponent(bidderRequest.refererInfo.referer);
49+
// TODO: is 'page' the right value here?
50+
var referer = encodeURIComponent(bidderRequest.refererInfo.page);
5051
var e = getBidIdParameter('endpoint', bidRequest.params);
5152
var ENDPOINT = e == 'dev' ? ENDPOINT_DEV : e == 'staging' ? ENDPOINT_STAGING : ENDPOINT_PRODUCTION;
5253
var mediaType = spec.getMediaType(bidRequest);

modules/craftBidAdapter.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,8 @@ export const spec = {
5151
}
5252
if (bidderRequest && bidderRequest.refererInfo) {
5353
let refererinfo = {
54-
rd_ref: bidderRequest.refererInfo.referer,
54+
// TODO: this collects everything it finds, except for the canonical URL
55+
rd_ref: bidderRequest.refererInfo.topmostLocation,
5556
rd_top: bidderRequest.refererInfo.reachedTop,
5657
rd_ifs: bidderRequest.refererInfo.numIframes,
5758
};

modules/criteoBidAdapter.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,9 +224,9 @@ function publisherTagAvailable() {
224224
function buildContext(bidRequests, bidderRequest) {
225225
let referrer = '';
226226
if (bidderRequest && bidderRequest.refererInfo) {
227-
referrer = bidderRequest.refererInfo.referer;
227+
referrer = bidderRequest.refererInfo.page;
228228
}
229-
const queryString = parseUrl(referrer).search;
229+
const queryString = parseUrl(bidderRequest?.refererInfo?.topmostLocation).search;
230230

231231
const context = {
232232
url: referrer,

test/spec/modules/cpmstarBidAdapter_spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const valid_bid_requests = [{
1414

1515
const bidderRequest = {
1616
refererInfo: {
17-
referer: 'referer',
17+
page: 'referer',
1818
reachedTop: false,
1919
}
2020
};

test/spec/modules/craftBidAdapter_spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ describe('craftAdapter', function () {
7575
}];
7676
let bidderRequest = {
7777
refererInfo: {
78-
referer: 'https://www.gacraft.jp/publish/craft-prebid-example.html'
78+
topmostLocation: 'https://www.gacraft.jp/publish/craft-prebid-example.html'
7979
}
8080
};
8181
it('sends bid request to ENDPOINT via POST', function () {

test/spec/modules/criteoBidAdapter_spec.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,8 @@ describe('The Criteo bidding adapter', function () {
404404
const refererUrl = 'https://criteo.com?pbt_debug=1&pbt_nolog=1';
405405
const bidderRequest = {
406406
refererInfo: {
407-
referer: refererUrl
407+
page: refererUrl,
408+
topmostLocation: refererUrl
408409
},
409410
timeout: 3000,
410411
gdprConsent: {
@@ -553,7 +554,8 @@ describe('The Criteo bidding adapter', function () {
553554
it('should properly build a networkId request', function () {
554555
const bidderRequest = {
555556
refererInfo: {
556-
referer: refererUrl
557+
page: refererUrl,
558+
topmostLocation: refererUrl,
557559
},
558560
timeout: 3000,
559561
gdprConsent: {
@@ -600,7 +602,8 @@ describe('The Criteo bidding adapter', function () {
600602
it('should properly build a mixed request', function () {
601603
const bidderRequest = {
602604
refererInfo: {
603-
referer: refererUrl
605+
page: refererUrl,
606+
topmostLocation: refererUrl,
604607
},
605608
timeout: 3000
606609
};

0 commit comments

Comments
 (0)