Skip to content

Commit 8fe3e53

Browse files
OctaviaS20Octavia Suceava
andauthored
deleted bidder name check (#12157)
Co-authored-by: Octavia Suceava <[email protected]>
1 parent 1231b4c commit 8fe3e53

File tree

2 files changed

+2
-9
lines changed

2 files changed

+2
-9
lines changed

modules/connatixBidAdapter.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,20 +75,17 @@ export const spec = {
7575
const bidId = deepAccess(bid, 'bidId');
7676
const mediaTypes = deepAccess(bid, 'mediaTypes', {});
7777
const params = deepAccess(bid, 'params', {});
78-
const bidder = deepAccess(bid, 'bidder');
7978

8079
const hasBidId = Boolean(bidId);
81-
const isValidBidder = (bidder === BIDDER_CODE);
8280
const hasMediaTypes = Boolean(mediaTypes) && (Boolean(mediaTypes[BANNER]) || Boolean(mediaTypes[VIDEO]));
8381
const isValidBanner = validateBanner(mediaTypes);
8482
const isValidVideo = validateVideo(mediaTypes);
8583
const hasRequiredBidParams = Boolean(params.placementId);
8684

87-
const isValid = isValidBidder && hasBidId && hasMediaTypes && isValidBanner && isValidVideo && hasRequiredBidParams;
85+
const isValid = hasBidId && hasMediaTypes && isValidBanner && isValidVideo && hasRequiredBidParams;
8886
if (!isValid) {
8987
logError(
90-
`Invalid bid request:
91-
isValidBidder: ${isValidBidder},
88+
`Invalid bid request:
9289
hasBidId: ${hasBidId},
9390
hasMediaTypes: ${hasMediaTypes},
9491
isValidBanner: ${isValidBanner},

test/spec/modules/connatixBidAdapter_spec.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,6 @@ describe('connatixBidAdapter', function () {
5252
it('Should return true if all required fileds are present', function () {
5353
expect(spec.isBidRequestValid(bid)).to.be.true;
5454
});
55-
it('Should return false if bidder does not correspond', function () {
56-
bid.bidder = 'abc';
57-
expect(spec.isBidRequestValid(bid)).to.be.false;
58-
});
5955
it('Should return false if bidId is missing', function () {
6056
delete bid.bidId;
6157
expect(spec.isBidRequestValid(bid)).to.be.false;

0 commit comments

Comments
 (0)