Skip to content

Commit 5ec60e4

Browse files
dgirardidgirardi
committed
convert bidders: operaads
1 parent e6bd48c commit 5ec60e4

12 files changed

+29
-25
lines changed

‎modules/mytargetBidAdapter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ export const spec = {
5151
let referrer = '';
5252

5353
if (bidderRequest && bidderRequest.refererInfo) {
54-
referrer = bidderRequest.refererInfo.referer;
54+
referrer = bidderRequest.refererInfo.page;
5555
}
5656

5757
const payload = {

‎modules/nativoBidAdapter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ export const spec = {
138138
pageUrl = deepAccess(
139139
request,
140140
'params.url',
141-
bidderRequest.refererInfo.referer
141+
bidderRequest.refererInfo.page
142142
)
143143
placementId = deepAccess(request, 'params.placementId')
144144

‎modules/nextrollBidAdapter.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ export const spec = {
3939
* @return ServerRequest Info describing the request to the server.
4040
*/
4141
buildRequests: function (validBidRequests, bidderRequest) {
42-
let topLocation = parseUrl(deepAccess(bidderRequest, 'refererInfo.referer'));
42+
// TODO: is 'page' the right value here?
43+
let topLocation = parseUrl(deepAccess(bidderRequest, 'refererInfo.page'));
4344

4445
return validBidRequests.map((bidRequest) => {
4546
return {

‎modules/nexx360BidAdapter.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,8 @@ export const spec = {
5959
});
6060
const payload = {
6161
adUnits,
62-
href: encodeURIComponent(bidderRequest.refererInfo.referer)
62+
// TODO: does the fallback make sense here?
63+
href: encodeURIComponent(bidderRequest.refererInfo.page || bidderRequest.refererInfo.topmostLocation)
6364
};
6465
if (bidderRequest) { // modules informations (gdpr, ccpa, schain, userId)
6566
if (bidderRequest.gdprConsent) {

‎modules/nobidBidAdapter.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,10 @@ function nobidBuildRequests(bids, bidderRequest) {
8888
}
8989
var topLocation = function(bidderRequest) {
9090
var ret = '';
91-
if (bidderRequest && bidderRequest.refererInfo && bidderRequest.refererInfo.referer) {
92-
ret = bidderRequest.refererInfo.referer;
91+
if (bidderRequest?.refererInfo?.page) {
92+
ret = bidderRequest.refererInfo.page;
9393
} else {
94+
// TODO: does this fallback make sense here?
9495
ret = (window.context && window.context.location && window.context.location.href) ? window.context.location.href : document.location.href;
9596
}
9697
return encodeURIComponent(ret.replace(/\%/g, ''));

‎modules/onomagicBidAdapter.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ function buildRequests(bidReqs, bidderRequest) {
1919
try {
2020
let referrer = '';
2121
if (bidderRequest && bidderRequest.refererInfo) {
22-
referrer = bidderRequest.refererInfo.referer;
22+
referrer = bidderRequest.refererInfo.page;
2323
}
2424
const onomagicImps = [];
2525
const publisherId = getBidIdParameter('publisherId', bidReqs[0].params);
@@ -56,7 +56,8 @@ function buildRequests(bidReqs, bidderRequest) {
5656
id: getUniqueIdentifierStr(),
5757
imp: onomagicImps,
5858
site: {
59-
domain: parseUrl(referrer).host,
59+
// TODO: does the fallback make sense here?
60+
domain: bidderRequest?.refererInfo?.domain || window.location.hostname,
6061
page: referrer,
6162
publisher: {
6263
id: publisherId

‎modules/openwebBidAdapter.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,8 @@ function parseRTBResponse(serverResponse, adapterRequest) {
126126
function bidToTag(bidRequests, adapterRequest) {
127127
// start publisher env
128128
const tag = {
129-
Domain: deepAccess(adapterRequest, 'refererInfo.referer')
129+
// TODO: is 'page' the right value here?
130+
Domain: deepAccess(adapterRequest, 'refererInfo.page')
130131
};
131132
if (config.getConfig('coppa') === true) {
132133
tag.Coppa = 1;

‎modules/openxBidAdapter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ function buildCommonQueryParamsFromBids(bids, bidderRequest) {
258258
let defaultParams;
259259

260260
defaultParams = {
261-
ju: config.getConfig('pageUrl') || bidderRequest.refererInfo.referer,
261+
ju: bidderRequest.refererInfo.page,
262262
ch: document.charSet || document.characterSet,
263263
res: `${screen.width}x${screen.height}x${screen.colorDepth}`,
264264
ifr: isInIframe,

‎modules/operaadsBidAdapter.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -209,8 +209,6 @@ export const spec = {
209209
* @returns {Request}
210210
*/
211211
function buildOpenRtbBidRequest(bidRequest, bidderRequest) {
212-
const pageReferrer = deepAccess(bidderRequest, 'refererInfo.referer');
213-
214212
// build OpenRTB request body
215213
const payload = {
216214
id: bidderRequest.auctionId,
@@ -220,9 +218,10 @@ function buildOpenRtbBidRequest(bidRequest, bidderRequest) {
220218
device: getDevice(),
221219
site: {
222220
id: String(deepAccess(bidRequest, 'params.publisherId')),
223-
domain: getDomain(pageReferrer),
224-
page: pageReferrer,
225-
ref: window.self === window.top ? document.referrer : '',
221+
// TODO: does the fallback make sense here?
222+
domain: bidderRequest?.refererInfo?.domain || window.location.hostname,
223+
page: bidderRequest?.refererInfo?.page,
224+
ref: bidderRequest?.refererInfo?.ref || '',
226225
},
227226
at: 1,
228227
bcat: getBcat(bidRequest),

‎test/spec/modules/mytargetBidAdapter_spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ describe('MyTarget Adapter', function() {
4646
];
4747
let bidderRequest = {
4848
refererInfo: {
49-
referer: 'https://example.com?param=value'
49+
page: 'https://example.com?param=value'
5050
}
5151
};
5252

‎test/spec/modules/nobidBidAdapter_spec.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ describe('Nobid Adapter', function () {
7070
];
7171

7272
let bidderRequest = {
73-
refererInfo: {referer: REFERER}, bidderCode: BIDDER_CODE
73+
refererInfo: {page: REFERER}, bidderCode: BIDDER_CODE
7474
}
7575

7676
const siteName = 'example';
@@ -132,7 +132,7 @@ describe('Nobid Adapter', function () {
132132
];
133133

134134
let bidderRequest = {
135-
refererInfo: {referer: REFERER}, bidderCode: BIDDER_CODE
135+
refererInfo: {page: REFERER}, bidderCode: BIDDER_CODE
136136
}
137137

138138
it('should add source and version to the tag', function () {
@@ -306,7 +306,7 @@ describe('Nobid Adapter', function () {
306306
];
307307

308308
let bidderRequest = {
309-
refererInfo: {referer: REFERER}
309+
refererInfo: {page: REFERER}
310310
}
311311

312312
it('should add source and version to the tag', function () {
@@ -395,7 +395,7 @@ describe('Nobid Adapter', function () {
395395
];
396396

397397
let bidderRequest = {
398-
refererInfo: {referer: REFERER}
398+
refererInfo: {page: REFERER}
399399
}
400400

401401
it('should add source and version to the tag', function () {
@@ -481,7 +481,7 @@ describe('Nobid Adapter', function () {
481481
];
482482

483483
let bidderRequest = {
484-
refererInfo: {referer: REFERER}
484+
refererInfo: {page: REFERER}
485485
}
486486

487487
it('should criteo eid', function () {
@@ -515,7 +515,7 @@ describe('Nobid Adapter', function () {
515515
];
516516

517517
let bidderRequest = {
518-
refererInfo: {referer: REFERER}
518+
refererInfo: {page: REFERER}
519519
}
520520

521521
it('should add source and version to the tag', function () {
@@ -649,7 +649,7 @@ describe('Nobid Adapter', function () {
649649
];
650650

651651
let bidderRequest = {
652-
refererInfo: {referer: REFERER}
652+
refererInfo: {page: REFERER}
653653
}
654654

655655
it('should refreshCount = 4', function () {

‎test/spec/modules/operaadsBidAdapter_spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ describe('Opera Ads Bid Adapter', function () {
4949
bidderCode: 'myBidderCode',
5050
bidderRequestId: '15246a574e859f',
5151
refererInfo: {
52-
referer: 'http://example.com',
52+
page: 'http://example.com',
5353
stack: ['http://example.com']
5454
},
5555
gdprConsent: {
@@ -242,7 +242,7 @@ describe('Opera Ads Bid Adapter', function () {
242242
expect(requestData.site).to.be.an('object');
243243
expect(requestData.site.id).to.equal(bidRequest.params.publisherId);
244244
expect(requestData.site.domain).to.not.be.empty;
245-
expect(requestData.site.page).to.equal(bidderRequest.refererInfo.referer);
245+
expect(requestData.site.page).to.equal(bidderRequest.refererInfo.page);
246246
expect(requestData.at).to.equal(1);
247247
expect(requestData.bcat).to.be.an('array').that.is.empty;
248248
expect(requestData.cur).to.be.an('array').that.not.be.empty;

0 commit comments

Comments
 (0)