Skip to content

Commit 50f0610

Browse files
committed
convert bidders: kobler
1 parent 8ba55cd commit 50f0610

File tree

5 files changed

+11
-8
lines changed

5 files changed

+11
-8
lines changed

modules/jixieBidAdapter.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,10 +116,12 @@ function getMiscDims_() {
116116
mkeywords: ''
117117
}
118118
try {
119+
// TODO: this should pick refererInfo from bidderRequest
119120
let refererInfo_ = getRefererInfo();
120-
let url_ = ((refererInfo_ && refererInfo_.referer) ? refererInfo_.referer : window.location.href);
121+
// TODO: does the fallback make sense here?
122+
let url_ = refererInfo_?.page || window.location.href
121123
ret.pageurl = url_;
122-
ret.domain = parseUrl(url_).host;
124+
ret.domain = refererInfo_?.domain || window.location.hostname
123125
ret.device = getDevice_();
124126
let keywords = document.getElementsByTagName('meta')['keywords'];
125127
if (keywords && keywords.content) {

modules/justpremiumBidAdapter.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ export const spec = {
2525
}).filter((value, index, self) => {
2626
return self.indexOf(value) === index
2727
}),
28-
referer: bidderRequest.refererInfo.referer,
28+
// TODO: is 'page' the right value here?
29+
referer: bidderRequest.refererInfo.page,
2930
sw: dim.screenWidth,
3031
sh: dim.screenHeight,
3132
ww: dim.innerWidth,

modules/kargoBidAdapter.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,7 @@ export const spec = {
213213
_getAllMetadata(tdid, usp, gdpr) {
214214
return {
215215
userIDs: spec._getUserIds(tdid, usp, gdpr),
216+
// TODO: this should probably look at refererInfo
216217
pageURL: window.location.href,
217218
rawCRB: spec._readCookie('krg_crb'),
218219
rawCRBLocalStorage: spec._getLocalStorageSafely('krg_crb')

modules/koblerBidAdapter.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,9 +94,8 @@ export const onTimeout = function (timeoutDataArray) {
9494
function buildOpenRtbBidRequestPayload(validBidRequests, bidderRequest) {
9595
const imps = validBidRequests.map(buildOpenRtbImpObject);
9696
const timeout = bidderRequest.timeout || config.getConfig('bidderTimeout') || DEFAULT_TIMEOUT;
97-
const pageUrl = (bidderRequest.refererInfo && bidderRequest.refererInfo.referer)
98-
? bidderRequest.refererInfo.referer
99-
: window.location.href;
97+
// TODO: does the fallback make sense here?
98+
const pageUrl = bidderRequest.refererInfo?.page || window.location.href
10099

101100
const request = {
102101
id: bidderRequest.auctionId,

test/spec/modules/koblerBidAdapter_spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ function createBidderRequest(auctionId, timeout, pageUrl) {
1010
auctionId: auctionId || 'c1243d83-0bed-4fdb-8c76-42b456be17d0',
1111
timeout: timeout || 2000,
1212
refererInfo: {
13-
referer: pageUrl || 'example.com'
13+
page: pageUrl || 'example.com'
1414
}
1515
};
1616
}
@@ -301,7 +301,7 @@ describe('KoblerAdapter', function () {
301301
const bidderRequest = {
302302
auctionId: 'c1243d83-0bed-4fdb-8c76-42b456be17d0',
303303
refererInfo: {
304-
referer: 'example.com'
304+
page: 'example.com'
305305
}
306306
};
307307
config.setConfig({

0 commit comments

Comments
 (0)