Skip to content

Commit 4d1f12e

Browse files
patmmccannpatmmccann
authored
Revert "AdTelligent Bid Adapter: remove onefiftytwo alias (#10025)" (#10032)
This reverts commit 88dbc04.
1 parent 88dbc04 commit 4d1f12e

16 files changed

+37
-503
lines changed

‎integrationExamples/gpt/growthcode.html

Lines changed: 9 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,10 @@
77
<script async src="../../build/dev/prebid.js"></script>
88
<script async src="https://www.googletagservices.com/tag/js/gpt.js"></script>
99
<script>
10-
var FAILSAFE_TIMEOUT = 33000;
11-
var PREBID_TIMEOUT = 10000;
10+
var FAILSAFE_TIMEOUT = 3300;
11+
var PREBID_TIMEOUT = 1000;
1212

1313
var adUnits = [{
14-
debugging: {
15-
enabled: true
16-
},
1714
code: 'div-gpt-ad-1460505748561-0',
1815
mediaTypes: {
1916
banner: {
@@ -26,11 +23,6 @@
2623
params: {
2724
placementId: 13144370
2825
}
29-
},{
30-
bidder: 'criteo',
31-
params: {
32-
zoneId: 497747
33-
},
3426
}],
3527
}];
3628

@@ -75,15 +67,12 @@
7567
pbjs.setConfig({
7668
debugging: {
7769
enabled: true,
78-
},
79-
realTimeData: {
80-
auctionDelay: 1000,
81-
dataProviders: [{
82-
name: 'growthCodeRtd',
83-
waitForIt: true,
84-
params: {
85-
pid: 'TEST01',
86-
}
70+
bids: [{
71+
bidder: 'appnexus',
72+
adUnitCode: '/19968336/header-bid-tag-0',
73+
cpm: 1.5,
74+
adId: '111111',
75+
ad: '<html><body><img src="https://files.prebid.org/creatives/prebid300x250.png"></body></html>'
8776
}]
8877
},
8978
userSync: {
@@ -92,7 +81,7 @@
9281
storage: {
9382
type: "html5",
9483
name: "_sharedID", // create a cookie with this name
95-
expires: 365 // expires in 1 year
84+
expires: 365 // expires in 1 years
9685
}
9786
},{
9887
name: 'growthCodeId',

‎modules/adgenerationBidAdapter.js

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import {tryAppendQueryString, getBidIdParameter, escapeUnsafeChars, deepAccess} from '../src/utils.js';
1+
import {tryAppendQueryString, getBidIdParameter, escapeUnsafeChars} from '../src/utils.js';
22
import {registerBidder} from '../src/adapters/bidderFactory.js';
33
import {BANNER, NATIVE} from '../src/mediaTypes.js';
44
import {config} from '../src/config.js';
5-
import {convertOrtbRequestToProprietaryNative} from '../src/native.js';
5+
import { convertOrtbRequestToProprietaryNative } from '../src/native.js';
66

77
const ADG_BIDDER_CODE = 'adgeneration';
88

@@ -21,14 +21,14 @@ export const spec = {
2121
},
2222
/**
2323
* Make a server request from the list of BidRequests.
24-
* @param validBidRequests
25-
* @param bidderRequest
24+
*
25+
* @param {validBidRequests[]} - an array of bids
2626
* @return ServerRequest Info describing the request to the server.
2727
*/
2828
buildRequests: function (validBidRequests, bidderRequest) {
2929
// convert Native ORTB definition to old-style prebid native definition
3030
validBidRequests = convertOrtbRequestToProprietaryNative(validBidRequests);
31-
const ADGENE_PREBID_VERSION = '1.6.0';
31+
const ADGENE_PREBID_VERSION = '1.5.0';
3232
let serverRequests = [];
3333
for (let i = 0, len = validBidRequests.length; i < len; i++) {
3434
const validReq = validBidRequests[i];
@@ -38,9 +38,6 @@ export const spec = {
3838
const criteoId = getCriteoId(validReq);
3939
const id5id = getId5Id(validReq);
4040
const id5LinkType = getId5LinkType(validReq);
41-
const imuid = deepAccess(validReq, 'userId.imuid');
42-
const gpid = deepAccess(validReq, 'ortb2Imp.ext.gpid');
43-
const sua = deepAccess(validReq, 'ortb2.device.sua');
4441
let data = ``;
4542
data = tryAppendQueryString(data, 'posall', 'SSPLOC');
4643
const id = getBidIdParameter('id', validReq.params);
@@ -57,12 +54,6 @@ export const spec = {
5754
data = tryAppendQueryString(data, 'adgext_criteo_id', criteoId);
5855
data = tryAppendQueryString(data, 'adgext_id5_id', id5id);
5956
data = tryAppendQueryString(data, 'adgext_id5_id_link_type', id5LinkType);
60-
data = tryAppendQueryString(data, 'adgext_imuid', imuid);
61-
data = tryAppendQueryString(data, 'adgext_uid2', validReq.userId ? validReq.userId.uid2 : null);
62-
data = tryAppendQueryString(data, 'gpid', gpid ? encodeURIComponent(gpid) : null);
63-
data = tryAppendQueryString(data, 'uach', sua ? JSON.stringify(sua) : null);
64-
data = tryAppendQueryString(data, 'schain', validReq.schain ? encodeURIComponent(JSON.stringify(validReq.schain)) : null);
65-
6657
// native以外にvideo等の対応が入った場合は要修正
6758
if (!validReq.mediaTypes || !validReq.mediaTypes.native) {
6859
data = tryAppendQueryString(data, 'imark', '1');

‎modules/adtelligentBidAdapter.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ const HOST_GETTERS = {
1717
}()),
1818
navelix: () => 'ghb.hb.navelix.com',
1919
appaloosa: () => 'ghb.hb.appaloosa.media',
20+
onefiftytwomedia: () => 'ghb.ads.152media.com',
2021
bidsxchange: () => 'ghb.hbd.bidsxchange.com',
2122
streamkey: () => 'ghb.hb.streamkey.net',
2223
janet: () => 'ghb.bidder.jmgads.com',
@@ -41,6 +42,7 @@ export const spec = {
4142
code: BIDDER_CODE,
4243
gvlid: 410,
4344
aliases: [
45+
'onefiftytwomedia',
4446
'appaloosa',
4547
'bidsxchange',
4648
'streamkey',

‎modules/growthCodeRtdProvider.js

Lines changed: 0 additions & 131 deletions
This file was deleted.

‎modules/growthCodeRtdProvider.md

Lines changed: 0 additions & 55 deletions
This file was deleted.

‎modules/ixBidAdapter.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,6 @@ export const FEATURE_TOGGLES = {
145145
let siteID = 0;
146146
let gdprConsent = '';
147147
let usPrivacy = '';
148-
let defaultVideoPlacement = false;
149148

150149
// Possible values for bidResponse.seatBid[].bid[].mtype which indicates the type of the creative markup so that it can properly be associated with the right sub-object of the BidRequest.Imp.
151150
const MEDIA_TYPES = {
@@ -224,8 +223,7 @@ function bidToVideoImp(bid) {
224223
if (deepAccess(videoParamRef, 'playerConfig.floatOnScroll')) {
225224
imp.video.placement = 5;
226225
} else {
227-
imp.video.placement = 3;
228-
defaultVideoPlacement = true;
226+
imp.video.placement = 4;
229227
}
230228
} else {
231229
logWarn(`IX Bid Adapter: Video context '${context}' is not supported`);
@@ -1114,8 +1112,7 @@ function buildIXDiag(validBidRequests) {
11141112
ren: false,
11151113
version: '$prebid.version$',
11161114
userIds: _getUserIds(validBidRequests[0]),
1117-
url: window.location.href.split('?')[0],
1118-
vpd: defaultVideoPlacement
1115+
url: window.location.href.split('?')[0]
11191116
};
11201117

11211118
// create ad unit map and collect the required diag properties

‎modules/sharethroughBidAdapter.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,8 @@ export const sharethroughAdapterSpec = {
9393
if (videoRequest) {
9494
// default playerSize, only change this if we know width and height are properly defined in the request
9595
let [w, h] = [640, 360];
96-
if (videoRequest.playerSize && videoRequest.playerSize[0] && videoRequest.playerSize[0][0] && videoRequest.playerSize[0][1]) {
97-
[w, h] = videoRequest.playerSize[0];
96+
if (videoRequest.playerSize && videoRequest.playerSize[0] && videoRequest.playerSize[1]) {
97+
[w, h] = videoRequest.playerSize;
9898
}
9999

100100
impression.video = {

‎modules/smartadserverBidAdapter.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -159,11 +159,6 @@ export const spec = {
159159
sdc: sellerDefinedContext
160160
};
161161

162-
const gpid = deepAccess(bid, 'ortb2Imp.ext.gpid', deepAccess(bid, 'ortb2Imp.ext.data.pbadslot', ''));
163-
if (gpid) {
164-
payload.gpid = gpid;
165-
}
166-
167162
if (bidderRequest) {
168163
if (bidderRequest.gdprConsent) {
169164
payload.addtl_consent = bidderRequest.gdprConsent.addtlConsent;

0 commit comments

Comments
 (0)