Skip to content

Commit 37c735a

Browse files
committed
convert bidders: glomex
1 parent 9feb6f5 commit 37c735a

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

modules/glomexBidAdapter.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,11 @@ export const spec = {
2626
data: {
2727
auctionId: bidderRequest.auctionId,
2828
refererInfo: {
29+
// TODO: this collects everything it finds, except for canonicalUrl
2930
isAmp: refererInfo.isAmp,
3031
numIframes: refererInfo.numIframes,
3132
reachedTop: refererInfo.reachedTop,
32-
referer: refererInfo.referer
33+
referer: refererInfo.topmostLocation,
3334
},
3435
gdprConsent: {
3536
consentString: gdprConsent.consentString,

test/spec/modules/glomexBidAdapter_spec.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ const BIDDER_REQUEST = {
2121
isAmp: true,
2222
numIframes: 0,
2323
reachedTop: true,
24-
referer: 'https://glomex.com'
24+
topmostLocation: 'https://glomex.com'
2525
},
2626
gdprConsent: {
2727
gdprApplies: true,
@@ -91,7 +91,12 @@ describe('glomexBidAdapter', function () {
9191
})
9292

9393
it('sends refererInfo', function () {
94-
expect(request.data.refererInfo).to.eql(BIDDER_REQUEST.refererInfo)
94+
const expected = {
95+
...BIDDER_REQUEST.refererInfo,
96+
referer: BIDDER_REQUEST.refererInfo.topmostLocation
97+
}
98+
delete expected.topmostLocation;
99+
expect(request.data.refererInfo).to.eql(expected)
95100
})
96101

97102
it('sends gdprConsent', function () {

test/spec/refererDetection_spec.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -499,14 +499,13 @@ describe('ensureProtocol', () => {
499499

500500
describe('parseDomain', () => {
501501
Object.entries({
502-
'example.com': 'example.com',
503502
'www.example.com': 'www.example.com',
504503
'example.com:443': 'example.com:443',
505504
'www.sub.example.com': 'www.sub.example.com',
506505
'example.com/page': 'example.com',
507506
'www.example.com:443/page': 'www.example.com:443',
508507
'http://www.example.com:443/page?query=value': 'www.example.com:443',
509-
'': undefined
508+
'': undefined,
510509
}).forEach(([input, expected]) => {
511510
it(`should extract domain from '${input}' -> '${expected}`, () => {
512511
expect(parseDomain(input)).to.equal(expected);

0 commit comments

Comments
 (0)