Skip to content

Commit 324d157

Browse files
author
Mike Groh
committed
there were some changes to the bid factory after our initial release that we didn't account for. Changing adapter to account for response body and required params.
1 parent 40444f7 commit 324d157

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

modules/trionBidAdapter.js

+7-2
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,10 @@ export const spec = {
3333
var bid = {};
3434
var bidResponses = [];
3535
var bidRequest = request.bidRequest;
36+
var responseBody = trionResponseObj ? trionResponseObj.body : {};
3637

37-
if (trionResponseObj && trionResponseObj.bidId && bidRequest) {
38-
var result = trionResponseObj.result;
38+
if (responseBody && responseBody.bidId && bidRequest) {
39+
var result = responseBody.result;
3940

4041
if (result && result.cpm && result.placeBid && result.ad) {
4142
var cpm = parseInt(result.cpm, 10) / 100;
@@ -45,6 +46,10 @@ export const spec = {
4546
bid.ad = result.ad;
4647
bid.width = result.width;
4748
bid.height = result.height;
49+
bid.ttl = result.ttl;
50+
bid.creativeId = result.creativeId;
51+
bid.currency = result.currency;
52+
bid.netRevenue = result.netRevenue;
4853
bidResponses.push(bid);
4954
}
5055
}

test/spec/modules/trionBidAdapter_spec.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ describe('Trion adapter tests', () => {
127127

128128
it('when place bid is returned as false', () => {
129129
TRION_BID_RESPONSE.result.placeBid = false;
130-
let response = spec.interpretResponse(TRION_BID_RESPONSE, {bidRequest: TRION_BID});
130+
let response = spec.interpretResponse({body: TRION_BID_RESPONSE}, {bidRequest: TRION_BID});
131131

132132
expect(response).to.deep.equal([]);
133133

@@ -136,14 +136,14 @@ describe('Trion adapter tests', () => {
136136

137137
it('when no cpm is in the response', () => {
138138
TRION_BID_RESPONSE.result.cpm = 0;
139-
let response = spec.interpretResponse(TRION_BID_RESPONSE, {bidRequest: TRION_BID});
139+
let response = spec.interpretResponse({body: TRION_BID_RESPONSE}, {bidRequest: TRION_BID});
140140
expect(response).to.deep.equal([]);
141141
TRION_BID_RESPONSE.result.cpm = 1;
142142
});
143143

144144
it('when no ad is in the response', () => {
145145
TRION_BID_RESPONSE.result.ad = null;
146-
let response = spec.interpretResponse(TRION_BID_RESPONSE, {bidRequest: TRION_BID});
146+
let response = spec.interpretResponse({body: TRION_BID_RESPONSE}, {bidRequest: TRION_BID});
147147
expect(response).to.deep.equal([]);
148148
TRION_BID_RESPONSE.result.ad = 'test';
149149
});
@@ -153,7 +153,7 @@ describe('Trion adapter tests', () => {
153153
let bidHeight = '2';
154154
TRION_BID_RESPONSE.result.width = bidWidth;
155155
TRION_BID_RESPONSE.result.height = bidHeight;
156-
let response = spec.interpretResponse(TRION_BID_RESPONSE, {bidRequest: TRION_BID});
156+
let response = spec.interpretResponse({body: TRION_BID_RESPONSE}, {bidRequest: TRION_BID});
157157
expect(response[0].width).to.equal(bidWidth);
158158
expect(response[0].height).to.equal(bidHeight);
159159
TRION_BID_RESPONSE.result.width = '300';
@@ -163,7 +163,7 @@ describe('Trion adapter tests', () => {
163163
it('cpm is properly set and transformed to cents', () => {
164164
let bidCpm = 2;
165165
TRION_BID_RESPONSE.result.cpm = bidCpm * 100;
166-
let response = spec.interpretResponse(TRION_BID_RESPONSE, {bidRequest: TRION_BID});
166+
let response = spec.interpretResponse({body: TRION_BID_RESPONSE}, {bidRequest: TRION_BID});
167167
expect(response[0].cpm).to.equal(bidCpm);
168168
TRION_BID_RESPONSE.result.cpm = 100;
169169
});

0 commit comments

Comments
 (0)