Skip to content

Commit 1fcf289

Browse files
committed
convert bidders: grid
1 parent 46bf009 commit 1fcf289

File tree

7 files changed

+14
-10
lines changed

7 files changed

+14
-10
lines changed

modules/gnetBidAdapter.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,8 @@ export const spec = {
3131
*/
3232
buildRequests: function (validBidRequests, bidderRequest) {
3333
const bidRequests = [];
34-
const referer = bidderRequest.refererInfo.referer;
34+
// TODO: is 'page' the right value?
35+
const referer = bidderRequest.refererInfo.page;
3536

3637
_each(validBidRequests, (request) => {
3738
const data = {};

modules/goldbachBidAdapter.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,8 @@ export const spec = {
246246

247247
if (bidderRequest && bidderRequest.refererInfo) {
248248
let refererinfo = {
249-
rd_ref: encodeURIComponent(bidderRequest.refererInfo.referer),
249+
// TODO: this collects everything it finds, except for topmostLocation
250+
rd_ref: encodeURIComponent(bidderRequest.refererInfo.topmostLocation),
250251
rd_top: bidderRequest.refererInfo.reachedTop,
251252
rd_ifs: bidderRequest.refererInfo.numIframes,
252253
rd_stk: bidderRequest.refererInfo.stack.map((url) => encodeURIComponent(url)).join(',')

modules/gothamadsBidAdapter.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,9 @@ export const spec = {
7474

7575
let winTop = window;
7676
let location;
77+
// TODO: this odd try-catch block was copied in several adapters; it doesn't seem to be correct for cross-origin
7778
try {
78-
location = new URL(bidderRequest.refererInfo.referer)
79+
location = new URL(bidderRequest.refererInfo.page)
7980
winTop = window.top;
8081
} catch (e) {
8182
location = winTop.location;

modules/gridBidAdapter.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,8 @@ export const spec = {
6060
let userExt = null;
6161
let {bidderRequestId, auctionId, gdprConsent, uspConsent, timeout, refererInfo} = bidderRequest || {};
6262

63-
const referer = refererInfo ? encodeURIComponent(refererInfo.referer) : '';
63+
// TODO: is 'page' the right value here?
64+
const referer = refererInfo ? encodeURIComponent(refererInfo.page) : '';
6465
const imp = [];
6566
const bidsMap = {};
6667

test/spec/modules/gnetBidAdapter_spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ describe('gnetAdapter', function () {
6969

7070
const bidderRequest = {
7171
refererInfo: {
72-
referer: 'https://gnetrtb.com'
72+
page: 'https://gnetrtb.com'
7373
}
7474
};
7575

test/spec/modules/goldbachBidAdapter_spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -802,7 +802,7 @@ describe('GoldbachXandrAdapter', function () {
802802
const bidRequest = Object.assign({}, bidRequests[0])
803803
const bidderRequest = {
804804
refererInfo: {
805-
referer: 'https://example.com/page.html',
805+
topmostLocation: 'https://example.com/page.html',
806806
reachedTop: true,
807807
numIframes: 2,
808808
stack: [

test/spec/modules/gridBidAdapter_spec.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,12 @@ describe('TheMediaGrid Adapter', function () {
4444
return JSON.parse(data);
4545
}
4646
const bidderRequest = {
47-
refererInfo: {referer: 'https://example.com'},
47+
refererInfo: {page: 'https://example.com'},
4848
bidderRequestId: '22edbae2733bf6',
4949
auctionId: '9e2dfbfe-00c7-4f5e-9850-4044df3229c7',
5050
timeout: 3000
5151
};
52-
const referrer = encodeURIComponent(bidderRequest.refererInfo.referer);
52+
const referrer = encodeURIComponent(bidderRequest.refererInfo.page);
5353
let bidRequests = [
5454
{
5555
'bidder': 'grid',
@@ -736,12 +736,12 @@ describe('TheMediaGrid Adapter', function () {
736736
'auctionId': 654645,
737737
};
738738
const bidderRequestWithNumId = {
739-
refererInfo: {referer: 'https://example.com'},
739+
refererInfo: {page: 'https://example.com'},
740740
bidderRequestId: 345345345,
741741
auctionId: 654645,
742742
timeout: 3000
743743
};
744-
const parsedReferrer = encodeURIComponent(bidderRequestWithNumId.refererInfo.referer);
744+
const parsedReferrer = encodeURIComponent(bidderRequestWithNumId.refererInfo.page);
745745
const request = spec.buildRequests([bidRequestWithNumId], bidderRequestWithNumId);
746746
expect(request.data).to.be.an('string');
747747
const payload = parseRequest(request.data);

0 commit comments

Comments
 (0)