ortbConverter: prepend nurl to creative markup (#13081)

dgirardi · web-flow · commit 127913bcb865 · 2025-05-13T11:05:25.000-04:00
diff --git a/libraries/ortbConverter/processors/banner.js b/libraries/ortbConverter/processors/banner.js
@@ -34,8 +34,7 @@ export function bannerResponseProcessor({createPixel = (url) => createTrackPixel
   return function fillBannerResponse(bidResponse, bid) {
     if (bidResponse.mediaType === BANNER) {
       if (bid.adm && bid.nurl) {
-        bidResponse.ad = bid.adm;
-        bidResponse.ad += createPixel(bid.nurl);
+        bidResponse.ad = createPixel(bid.nurl) + bid.adm;
       } else if (bid.adm) {
         bidResponse.ad = bid.adm;
       } else if (bid.nurl) {
diff --git a/test/spec/modules/a1MediaBidAdapter_spec.js b/test/spec/modules/a1MediaBidAdapter_spec.js
@@ -240,7 +240,7 @@ describe('a1MediaBidAdapter', function() {
         const interpretedRes = spec.interpretResponse(bidderResponse, bidRequest);
 
         const expectedResPrice = 9;
-        const expectedAd = replaceAuctionPrice(macroAdm, expectedResPrice) + replaceAuctionPrice(interpretedNurl, expectedResPrice);
+        const expectedAd = replaceAuctionPrice(interpretedNurl, expectedResPrice) + replaceAuctionPrice(macroAdm, expectedResPrice);
 
         expect(interpretedRes[0].ad).equal(expectedAd);
       });
diff --git a/test/spec/modules/conversantBidAdapter_spec.js b/test/spec/modules/conversantBidAdapter_spec.js
@@ -485,7 +485,7 @@ describe('Conversant adapter tests', function() {
       expect(bid).to.have.property('width', 300);
       expect(bid).to.have.property('height', 250);
       expect(bid.meta.advertiserDomains).to.deep.equal(['https://example.com']);
-      expect(bid).to.have.property('ad', 'markup000<div style="position:absolute;left:0px;top:0px;visibility:hidden;"><img src="notify000"></div>');
+      expect(bid).to.have.property('ad', '<div style="position:absolute;left:0px;top:0px;visibility:hidden;"><img src="notify000"></div>markup000');
       expect(bid).to.have.property('ttl', 300);
       expect(bid).to.have.property('netRevenue', true);
     });
@@ -499,7 +499,7 @@ describe('Conversant adapter tests', function() {
       expect(bid).to.have.property('creativeId', '1002');
       expect(bid).to.have.property('width', 300);
       expect(bid).to.have.property('height', 600);
-      expect(bid).to.have.property('ad', 'markup002<div style="position:absolute;left:0px;top:0px;visibility:hidden;"><img src="notify002"></div>');
+      expect(bid).to.have.property('ad', '<div style="position:absolute;left:0px;top:0px;visibility:hidden;"><img src="notify002"></div>markup002');
       expect(bid).to.have.property('ttl', 300);
       expect(bid).to.have.property('netRevenue', true);
     });
diff --git a/test/spec/modules/kimberliteBidAdapter_spec.js b/test/spec/modules/kimberliteBidAdapter_spec.js
@@ -217,7 +217,7 @@ describe('kimberliteBidAdapter', function () {
             creativeId: 1,
             ttl: 300,
             netRevenue: true,
-            ad: bannerAdm + nurlPixel,
+            ad: nurlPixel + bannerAdm,
             meta: {}
           },
           {
diff --git a/test/spec/modules/scatteredBidAdapter_spec.js b/test/spec/modules/scatteredBidAdapter_spec.js
@@ -192,7 +192,7 @@ describe('interpretResponse', function () {
   it('should set proper values', function () {
     const results = spec.interpretResponse(serverResponse, request);
     const expected = {
-      ad: '<html><img src="https://some_banner.jpeg></img></html><div style="position:absolute;left:0px;top:0px;visibility:hidden;"><img src="https://scattered.eu/nurl"></div>',
+      ad: '<div style="position:absolute;left:0px;top:0px;visibility:hidden;"><img src="https://scattered.eu/nurl"></div><html><img src="https://some_banner.jpeg></img></html>',
       cpm: '34.2',
       creativeId: '2345-2345-23',
       currency: 'PLN',
diff --git a/test/spec/modules/sparteoBidAdapter_spec.js b/test/spec/modules/sparteoBidAdapter_spec.js
@@ -365,7 +365,7 @@ describe('SparteoAdapter', function () {
             ttl: TTL,
             mediaType: 'banner',
             meta: {},
-            ad: 'script<div style=\"position:absolute;left:0px;top:0px;visibility:hidden;\"><img src=\"https://t.bidder.sparteo.com/img\"></div>'
+            ad: '<div style=\"position:absolute;left:0px;top:0px;visibility:hidden;\"><img src=\"https://t.bidder.sparteo.com/img\"></div>script'
           }
         ];
 
diff --git a/test/spec/ortbConverter/banner_spec.js b/test/spec/ortbConverter/banner_spec.js
@@ -195,7 +195,7 @@ describe('ortb -> pbjs banner conversion', () => {
       },
       expected: {
         mediaType: BANNER,
-        ad: 'mockAdmmockUrlPixel'
+        ad: 'mockUrlPixelmockAdm'
       }
     },
     {

Original file line number	Diff line number	Diff line change
`@@ -217,7 +217,7 @@ describe('kimberliteBidAdapter', function () {`
`217`	`217`	`creativeId: 1,`
`218`	`218`	`ttl: 300,`
`219`	`219`	`netRevenue: true,`
`220`		`- ad: bannerAdm + nurlPixel,`
	`220`	`+ ad: nurlPixel + bannerAdm,`
`221`	`221`	`meta: {}`
`222`	`222`	`},`
`223`	`223`	`{`
Original file line number	Diff line number	Diff line change
`@@ -365,7 +365,7 @@ describe('SparteoAdapter', function () {`
`365`	`365`	`ttl: TTL,`
`366`	`366`	`mediaType: 'banner',`
`367`	`367`	`meta: {},`
`368`		`- ad: 'script<div style=\"position:absolute;left:0px;top:0px;visibility:hidden;\"><img src=\"https://t.bidder.sparteo.com/img\"></div>'`
	`368`	`+ ad: '<div style=\"position:absolute;left:0px;top:0px;visibility:hidden;\"><img src=\"https://t.bidder.sparteo.com/img\"></div>script'`
`369`	`369`	`}`
`370`	`370`	`];`
`371`	`371`
Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@ describe('ortb -> pbjs banner conversion', () => {`
`195`	`195`	`},`
`196`	`196`	`expected: {`
`197`	`197`	`mediaType: BANNER,`
`198`		`- ad: 'mockAdmmockUrlPixel'`
	`198`	`+ ad: 'mockUrlPixelmockAdm'`
`199`	`199`	`}`
`200`	`200`	`},`
`201`	`201`	`{`